psalm-assert: array<array-key, mixed> is always non-empty-array<array-key, mixed>

[davidrans]

There seems to be a mistake somewhere about non-empty-array<mixed> being more general than array<mixed>. Possibly related to psalm-assert?

See: https://psalm.dev/r/86465e1208

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/86465e1208

<?php

function getTemplateVariables(array $arr): void {
    exceptionIfEmpty($arr);
}

/**
 * @psalm-assert non-empty-array $things
 */
function exceptionIfEmpty(array $things): void {
   if (!$things) {
      throw new Exception("headEx() called on an empty array");
   }
}

Psalm output (using commit a9e6444):

ERROR: RedundantCondition - 4:5 - Type array<array-key, mixed> for $arr is always non-empty-array<array-key, mixed>