Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on indentation #77

Open
mdb opened this issue Aug 10, 2019 · 3 comments
Open

Standardize on indentation #77

mdb opened this issue Aug 10, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mdb
Copy link
Contributor

mdb commented Aug 10, 2019

vinyldns-java appears to use a mix of 2 and 4 space indentation. Is it reasonable to standardize the indentation?

@pauljamescleary
Copy link
Contributor

@mdb probably just need to pick a formatter and stick with it. I think we went with google's java format plugin but probably can revisit

@mdb
Copy link
Contributor Author

mdb commented Aug 19, 2019

@pauljamescleary I defer to you all. My only complaint is that the indentation is inconsistent. Do the maintainers have an opinion on 2 space vs 4 space indentation? And an opinion on how to enforce this?

I haven't dug too deeply on how the currently-used format plugin is configured, but it seems to me that formatting isn't consistently maintained across all files.

@pauljamescleary pauljamescleary added the good first issue Good for newcomers label Oct 4, 2020
@pauljamescleary
Copy link
Contributor

This is a good first issue:

  1. Choose a maven plugin that does auto formatting using any standard convention in the java verse. I do not have a strong opinion on the formatting, rather that it is how most folks do things
  2. Ensure maven plugin auto formats code properly when building

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants