Don't register external login providers if key/secrets were not defined

Fix kriasoft#9

Author: koistya

package.json

@@ -58,8 +58,8 @@
     "postcss-selector-not": "^2.0.0",
     "react-hot-loader": "^3.0.0-beta.2",
     "style-loader": "^0.13.1",
-    "stylelint": "^6.5.1",
-    "stylelint-config-standard": "^8.0.0",
+    "stylelint": "^6.6.0",
+    "stylelint-config-standard": "^9.0.0",
     "url-loader": "^0.5.7",
     "webpack": "^2.1.0-beta.13",
     "webpack-dev-middleware": "^1.6.1",

server/Controllers/AccountController.cs

@@ -2,6 +2,8 @@
 // This source code is licensed under the MIT license found in the
 // LICENSE.txt file in the root directory of this source tree.
 
+using System.Collections.Generic;
+
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.Mvc;
@@ -15,21 +17,27 @@ public class AccountController : Controller
     {
         private readonly SignInManager<User> _signInManager;
         private readonly ILogger _logger;
+        private readonly SortedList<string, string> _providers;
 
         public AccountController(SignInManager<User> signInManager, ILoggerFactory loggerFactory)
         {
             _signInManager = signInManager;
             _logger = loggerFactory.CreateLogger<AccountController>();
+            _providers = new SortedList<string, string>
+            {
+                { "facebook", "Facebook" }
+            };
         }
 
         [HttpGet("login/{provider}")]
         [AllowAnonymous]
         public IActionResult ExternalLogin(string provider, string returnUrl = null)
         {
             // Request a redirect to the external login provider.
+            var providerName = _providers.ContainsKey(provider) ? _providers[provider] : provider;
             var redirectUrl = Url.Action("ExternalLoginCallback", "Account", new { ReturnUrl = returnUrl });
-            var properties = _signInManager.ConfigureExternalAuthenticationProperties(provider, redirectUrl);
-            return Challenge(properties, provider);
+            var properties = _signInManager.ConfigureExternalAuthenticationProperties(providerName, redirectUrl);
+            return Challenge(properties, providerName);
         }
 
         [HttpGet("auth")]

server/Startup.cs

@@ -68,16 +68,19 @@ public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerF
 
             // Enable external authentication provider(s)
             // https://docs.asp.net/en/latest/security/authentication/sociallogins.html
-            app.UseIdentity()
+            app.UseIdentity();
 
-                .UseFacebookAuthentication(new FacebookOptions
+            if (!string.IsNullOrEmpty(Configuration["Authentication:Facebook:AppId"]))
+            {
+                app.UseFacebookAuthentication(new FacebookOptions
                 {
                     AppId = Configuration["Authentication:Facebook:AppId"],
                     AppSecret = Configuration["Authentication:Facebook:AppSecret"],
                     Scope = { "email" },
                     Fields = { "name", "email" },
                     SaveTokens = true,
                 });
+            }
 
             // Configure ASP.NET MVC
             // https://docs.asp.net/en/latest/mvc/index.html

tools/appsettings.js

@@ -0,0 +1,27 @@
+/**
+ * ASP.NET Core Starter Kit
+ *
+ * Copyright © 2014-2016 Kriasoft, LLC. All rights reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE.txt file in the root directory of this source tree.
+ */
+
+const fs = require('fs');
+const path = require('path');
+const task = require('./lib/task');
+
+const environments = ['Production', 'Development'];
+
+// Create Production/Development configuration files if they don't exist
+module.exports = task('appsettings', () => new Promise(resolve => {
+  let count = environments.length;
+  const appSettings = require('../server/appsettings.json'); // use it as a template
+  delete appSettings.Logging;
+  environments.forEach(env => {
+    const filename = path.resolve(__dirname, `../server/appsettings.${env}.json`);
+    fs.writeFile(filename, JSON.stringify(appSettings, null, '  '), { flag: 'wx' }, () => {
+      if (--count === 0) resolve();
+    });
+  });
+}));

tools/build.js

@@ -20,17 +20,7 @@ module.exports = task('build', () => Promise.resolve()
   .then(() => require('./clean'))
 
   // Create Production/Development configuration files if they don't exist
-  .then(() => new Promise(resolve => {
-    let count = 2;
-    const appSettings = require('../server/appsettings.json'); // use it as a template
-    delete appSettings.Logging;
-    ['Production', 'Development'].forEach(env => {
-      const filename = path.resolve(__dirname, `../server/appsettings.${env}.json`);
-      fs.writeFile(filename, JSON.stringify(appSettings, null, '  '), { flag: 'wx' }, () => {
-        if (--count === 0) resolve();
-      });
-    });
-  }))
+  .then(() => require('./appsettings'))
 
   // Compile the ASP.NET Core app
   .then(() => cp.spawn(

tools/start.js

@@ -14,6 +14,11 @@ const webpackConfig = require('./webpack.config');
 const task = require('./lib/task');
 
 module.exports = task('start', () => Promise.resolve()
+  // Clean up the output directory
+  .then(() => require('./clean'))
+
+  // Create Production/Development configuration files if they don't exist
+  .then(() => require('./appsettings'))
 
   // Launch Webpack compiler in watch mode
   .then(() => new Promise((resolve, reject) => {
@@ -44,5 +49,4 @@ module.exports = task('start', () => Promise.resolve()
       }
     });
   }))
-
 );