Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] [pydeck] Allow overriding CDN URLs #9374

Open
bijanvakili opened this issue Jan 22, 2025 · 0 comments
Open

[Feat] [pydeck] Allow overriding CDN URLs #9374

bijanvakili opened this issue Jan 22, 2025 · 0 comments
Labels

Comments

@bijanvakili
Copy link
Contributor

Target Use Case

By default, pydeck references the JSDelivr Content Delivery Network in its URL to download embed the @deck.gl/jupyter-widget Javascript package which includes all required deck.gl packages.

  • Default URLs are specified here.
  • Uses semantic version specification here

There may be cases where clients may not wish to use a different CDN with pydeck (e.g. need different terms of use, service level agreements, etc.).

Proposal

pydeck.Deck itself need to be built to allow overriding the URLs by including a cdn_urls dictionary with the JS package names (@deck.gl/jupyter-widget) and (@deck.gl/jwidget) as keys. This would easily allow for more URLs in the future. This dictionary could then be propagated to the logic in cdn_picker here to
override both bundle URLs if required.

If the cdn_urls kwarg is not provided or any of its keys are missing, it can default to the current behavior.

@bijanvakili bijanvakili changed the title [Feat] [pydeck] Allow overriding CDN URls [Feat] [pydeck] Allow overriding CDN URLs Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant