Repository navigation
fix(legacy): respect quoted link attribute values - #23844
Open
leracherry wants to merge 1 commit into
Open
leracherry wants to merge 1 commit into
leracherry wants to merge 1 commit into
Conversation
leracherry
force-pushed
the
fix/legacy-modulepreload-quoted-attributes
branch
2 times, most recently
from
October 20, 2026 16:50
08a2603 to
5ac5351
Compare
Author
|
Could a maintainer review this plugin-legacy fix? CI passed on the current head, and the PR includes unit and browser regressions for quoted link attributes. Please let me know if any changes are needed. |
leracherry
force-pushed
the
fix/legacy-modulepreload-quoted-attributes
branch
from
November 9, 2026 19:56
1b3f14c to
0bd4331
Compare
Author
|
Could a maintainer rerun the failed Node 22 job and review this fix? The current branch is conflict-free. The latest CI failure is in the existing HMR test "should hmr when file is deleted and restored" (expected parent:child, received parent:not-child), outside this PR’s changed files. The other build/test matrix jobs and lint passed. I attempted a rerun but GitHub requires repository admin rights: https://github.com/vitejs/vite/actions/runs/42688154498/job/129400547466 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a legacy-only build, a stylesheet link can be removed if its
titlecontains text likerel="modulepreload". A>inside a quoted value can also end the match too early.Keep quoted attribute values together when matching modulepreload links. The browser regression checks that the stylesheet is preserved and still applies.
Follow-up to #22332. Refs #22320.
Rebased onto
db8b119. The build, 19 plugin-legacy unit tests, and 4 focused browser tests passed locally. The previous CI run passed on Linux, macOS, and Windows.