-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 8] Dynamic REST API routes #22
Draft
ghost
wants to merge
16
commits into
main
Choose a base branch
from
8-dynamic-rest-api-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update package lock file * refactor reducer to core store * remove default schematics collection * add api base url to environment * rest docs feature store * add state tests * fix effects test * fix prod base url * fix devtools * add prettierrc and format * update app component spec to run lifecycle hooks * refactor rest docs to rest api * test fail fetch api in effects * formatting * Updating of a resource request should use previous id (uri), not new one Co-authored-by: William Welling <[email protected]> Co-authored-by: chenejac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitro-angular GitHub issue: #8
What does this pull request do?
A brief description of what the intended result of the PR will be and/or what problem it solves.
What's new?
An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.
Example:
How should this be tested?
A description of what steps someone could take to:
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
package.json
), I've made sure their licenses align with the Vitro-angular License.