Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing the "Enabled" checkbox for a flow does not do anything #1

Open
vladimiroltean opened this issue Apr 18, 2018 · 0 comments
Open

Comments

@vladimiroltean
Copy link
Owner

vladimiroltean commented Apr 18, 2018

According to https://developer.mozilla.org/en-US/docs/Web/Events/input, the only browser that triggers "oninput" callbacks for checkbox HTML elements is Firefox (versions later than 49).
Here: https://github.com/vladimiroltean/lbt/blob/master/js/client.js#L149 is the "oninput" callback that will not get called on all other browsers.
The available workaround is to manually log in into the server, edit the flows.json file and set "enabled": true for the desired flows, then restart the application.
The proper fix would be to use a different DOM API for checkboxes that reacts to clicks and is more browser-interoperable than oninput is.

@vladimiroltean vladimiroltean changed the title Pressing "Save changes" Pressing "Save changes" ignores the value of the "Enabled" checkboxes Apr 18, 2018
@vladimiroltean vladimiroltean changed the title Pressing "Save changes" ignores the value of the "Enabled" checkboxes Pressing the "Enabled" checkbox for a flow does not do anything Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant