szip: zip_files() and zip_folder() should have options to change the used compression level #18647
rhoellwarth
started this conversation in
Ideas
Replies: 1 comment
-
PRs are always welcome! However, I would change compression_level CompressionLevel = .no_compression to the actual Zip default (6, isn't it? Whatever enum that corresponds to...). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Describe the feature
The two functions zip_files and zip_folder should have an option to control the level of compression.
Right now in both functions the compression level is hard coded with ".no_compression.
Use Case
The two functions now work like "tar" - they just create a single file that's not compressed. But when I read "zip" I always expect that the resultfile is compressed. Now I have to fiddle around with the details of szip instead of just using it.
Proposed Solution
For zip_folder I tried the following two changes - and they seamed to work. For zip_files there must be done some more work but it should be very likely:
Beta Was this translation helpful? Give feedback.
All reactions