Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to numpy >= 2.0.0 #6570

Open
fgebhart opened this issue Jul 19, 2024 · 5 comments · May be fixed by #12759
Open

Upgrade to numpy >= 2.0.0 #6570

fgebhart opened this issue Jul 19, 2024 · 5 comments · May be fixed by #12759
Labels

Comments

@fgebhart
Copy link

fgebhart commented Jul 19, 2024

Hi 👋

Would it be possible to upgrade the dependency of vLLM to numpy to remove the pinning here?

We are running into a dependency conflict issue in our dependency chain and would appreciate the move to support more recent numpy versions.

Thanks!

@fgebhart fgebhart added the misc label Jul 19, 2024
@fgebhart fgebhart changed the title [Misc]: Upgrade to numpy >= 2.0.0 Upgrade to numpy >= 2.0.0 Jul 19, 2024
@youkaichao
Copy link
Member

vLLM does not have a direct dependency on numpy, this is required for dependencies of vLLM, i.e. an indirect dependency. We need to wait for the open-source community to adopt numpy 2.0 first, only after that can we safely remove the constraint.

@chris-aeviator
Copy link

this is entirely confusing, e.g. pixi complains about vllm being the reason

  × failed to solve the pypi requirements of 'ray' 'linux-64'
  ├─▶ failed to resolve pypi dependencies
  ╰─▶ Because vllm>=0.6.0 depends on numpy<2.0.0 and numpy==2.1.2, we can conclude that vllm>=0.6.0 cannot be used.
      And because only the following versions of vllm are available:
          vllm<=0.6.0
          vllm==0.6.1
          vllm==0.6.1.post1
          vllm==0.6.1.post2
          vllm==0.6.2
          vllm==0.6.3
          vllm==0.6.3.post1
      and you require vllm>=0.6.0, we can conclude that your requirements are unsatisfiable.

@chris-aeviator
Copy link

vLLM does not have a direct dependency on numpy, this is required for dependencies of vLLM, i.e. an indirect dependency. We need to wait for the open-source community to adopt numpy 2.0 first, only after that can we safely remove the constraint.

@youkaichao this is false (or I misunderstand you) - see

numpy < 2.0.0
for the direct dependency

@youkaichao
Copy link
Member

@chris-aeviator I added this line to prevent numpy 2.0 . see #5582 (comment)

@rgommers
Copy link

Hi @youkaichao, the issue with Outlines was fixed in its 0.1.6 release ~1.5 months ago, see dottxt-ai/outlines#1265. According to the discussion in gh-5582, I think you can remove the pin now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants