Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add some way to detect or configure browser not to open #456

Open
lukekarrys opened this issue Feb 20, 2025 · 0 comments
Open

[FEATURE] Add some way to detect or configure browser not to open #456

lukekarrys opened this issue Feb 20, 2025 · 0 comments
Assignees
@lukekarrys
Labels
cli cli specific issues feature feature or request

Comments

@lukekarrys
Copy link
Member

lukekarrys commented Feb 20, 2025 •
edited by darcyclarke
Loading

i was trying to test #455 in the builds only and it was difficult because there was no way to configure the browser not to open.

we should either add a config for this or detect it based on stdout.isTTY / process.env.CI /something else
@darcyclarke darcyclarke changed the title some way to detect or configure browser not to open [FEATURE] Add some way to detect or configure browser not to open Feb 24, 2025
@darcyclarke darcyclarke added cli cli specific issues feature feature or request labels Feb 24, 2025 — with Linear
@lukekarrys lukekarrys mentioned this issue Mar 19, 2025
Merged
lukekarrys added a commit that referenced this issue Mar 19, 2025
@lukekarrys
build: read gui assets dir from env in builds (#541)
6eeeac2 
This is not the first time this has broken which means it definitely
needs a test but that is blocked by #456. I've confirmed this fix works
for me locally and will test that the GUI works when bundled/compiled as
part of fixing #456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukekarrys lukekarrys

Labels
cli cli specific issues feature feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darcyclarke @lukekarrys