[#112] ortools-backend: temporarily avoid overflow issues in o.mult()

Signed-off-by: Lalith Suresh <[email protected]>

Author: lalithsuresh

dcm/src/main/java/com/vmware/dcm/backend/ortools/Ops.java

@@ -252,8 +252,10 @@ public IntVar mult(final IntVar left, final int right) {
         final Domain domain = left.getDomain();
         final long lDomainMinResult = domain.min() * right;
         final long lDomainMaxResult = domain.max() * right;
-        final long lb = Math.min(lDomainMinResult, lDomainMaxResult);
-        final long ub = Math.max(lDomainMinResult, lDomainMaxResult);
+
+        // Conservative. Should be fixed with: https://github.com/vmware/declarative-cluster-management/issues/112
+        final long lb = Math.max(Math.min(lDomainMinResult, lDomainMaxResult), Integer.MIN_VALUE);
+        final long ub = Math.min(Math.max(lDomainMinResult, lDomainMaxResult), Integer.MAX_VALUE);
         final IntVar ret = model.newIntVar(lb, ub, "");
         model.addEquality(ret, LinearExpr.term(left, right));
         return ret;
@@ -266,8 +268,10 @@ public IntVar mult(final IntVar left, final IntVar right) {
         final long lDomainMax = lDomain.max();
         final long rDomainMin = rDomain.min();
         final long rDomainMax = rDomain.max();
-        final long lb = Math.min(lDomainMin * rDomainMin, lDomainMax * rDomainMax);
-        final long ub = Math.max(lDomainMin * rDomainMin, lDomainMax * rDomainMax);
+
+        // Conservative. Should be fixed with: https://github.com/vmware/declarative-cluster-management/issues/112
+        final long lb = Math.max(Math.min(lDomainMin * rDomainMin, lDomainMax * rDomainMax), Integer.MIN_VALUE);
+        final long ub = Math.min(Math.max(lDomainMin * rDomainMin, lDomainMax * rDomainMax), Integer.MAX_VALUE);
         final IntVar ret = model.newIntVar(lb, ub, "");
         model.addProductEquality(ret, new IntVar[]{left, right});
         return ret;

dcm/src/test/java/com/vmware/dcm/ModelTest.java

@@ -1686,7 +1686,6 @@ public void testStringCodeGen() {
         final Model model = Model.build(conn, views);
         model.updateData();
         final Result<? extends Record> t1 = model.solve("T1");
-        System.out.println(t1);
         assertEquals(42, t1.get(0).get(1));
     }