Skip to content

Commit a4a2fde

Browse files
EcljpseB0Tjukzi
authored andcommitted
use ScreenshotOnFailure TestWatcher
1 parent 8a8979f commit a4a2fde

File tree

4 files changed

+15
-30
lines changed

4 files changed

+15
-30
lines changed

tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
import org.junit.Rule;
7272
import org.junit.Test;
7373
import org.junit.rules.TestName;
74+
import org.junit.rules.TestWatcher;
7475
import org.osgi.service.log.LogLevel;
7576
import org.osgi.service.log.LogListener;
7677
import org.osgi.service.log.LogReaderService;
@@ -2972,6 +2973,9 @@ public void testBug371100() {
29722973
assertFalse(logged);
29732974
}
29742975

2976+
@Rule
2977+
public TestWatcher screenshotRule = Screenshots.onFailure();
2978+
29752979
@Test
29762980
public void testBug372226() {
29772981
assumeFalse("Test fails on Mac: Bug 537639", Platform.OS_MACOSX.equals(Platform.getOS()));
@@ -2991,8 +2995,6 @@ public void testBug372226() {
29912995
Control control = (Control) part.getWidget();
29922996
assertEquals(subShell, control.getParent());
29932997

2994-
Screenshots.takeScreenshot(getClass(), testName.getMethodName());
2995-
29962998
appContext.get(EPartService.class).activate(part);
29972999
assertEquals(subShell, control.getParent());
29983000
}

tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/ScreenshotOnFailureRule.java

-25
This file was deleted.

tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/TextViewerTest.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
import org.junit.Assume;
2929
import org.junit.Rule;
3030
import org.junit.Test;
31+
import org.junit.rules.TestWatcher;
32+
33+
import org.eclipse.test.Screenshots;
3134

3235
import org.eclipse.swt.SWT;
3336
import org.eclipse.swt.custom.StyledText;
@@ -73,7 +76,9 @@
7376
*/
7477
public class TextViewerTest {
7578

76-
@Rule public ScreenshotOnFailureRule screenshotRule = new ScreenshotOnFailureRule();
79+
@Rule
80+
public TestWatcher screenshotRule= Screenshots.onFailure();
81+
7782
private Shell fShell;
7883

7984
@After

tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
import org.junit.Before;
2626
import org.junit.Rule;
2727
import org.junit.Test;
28+
import org.junit.rules.TestWatcher;
29+
30+
import org.eclipse.test.Screenshots;
2831

2932
import org.eclipse.swt.SWT;
3033
import org.eclipse.swt.custom.StyleRange;
@@ -57,7 +60,6 @@
5760
import org.eclipse.jface.text.source.AnnotationModel;
5861
import org.eclipse.jface.text.source.AnnotationPainter;
5962
import org.eclipse.jface.text.source.SourceViewer;
60-
import org.eclipse.jface.text.tests.ScreenshotOnFailureRule;
6163
import org.eclipse.jface.text.tests.TextViewerTest;
6264
import org.eclipse.jface.text.tests.util.DisplayHelper;
6365

@@ -66,7 +68,8 @@ public class CodeMiningTest {
6668
private SourceViewer fViewer;
6769
private Shell fShell;
6870

69-
@Rule public ScreenshotOnFailureRule rule = new ScreenshotOnFailureRule();
71+
@Rule
72+
public TestWatcher screenshotRule= Screenshots.onFailure();
7073

7174
@Before
7275
public void setUp() {

0 commit comments

Comments
 (0)