Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Duplicate functionality in basis and standard basis #911

Open
vprusso opened this issue Dec 7, 2024 · 0 comments · May be fixed by #936
Open

Refactor: Duplicate functionality in basis and standard basis #911

vprusso opened this issue Dec 7, 2024 · 0 comments · May be fixed by #936
Labels
refactor

Comments

@vprusso
Copy link
Owner

vprusso commented Dec 7, 2024

We have the same functionality in the states/basis.py file and the matrices/standard_basis.py. We should restrict to having just one, preferably the latter of standard_basis.py.

This would involve removing basis.py as well as all references, tests, for this. Additionally, we will want to use standard_basis in place of anywhere we currently use basis.
@vprusso vprusso linked a pull request Jan 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove basis function in favor of standard_basis vprusso/toqito
1 participant
@vprusso