Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2417: Remove contact form, page and tests #2572

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Zharktas
Copy link
Contributor

Removes feedback contact form, the page displaying the form and related tests.

Contact module itself is not removed as submitting events are built upon it.

The basic page replacing the form needs to be added manually in environments.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.19%. Comparing base (f210342) to head (0369858).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2572   +/-   ##
=======================================
  Coverage   27.19%   27.19%           
=======================================
  Files          42       42           
  Lines        5923     5923           
  Branches       37       37           
=======================================
  Hits         1611     1611           
  Misses       4312     4312           
Flag Coverage Δ
cdk 96.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 24, 2025

opendata    Run #5333

Run Properties:  status check passed Passed #5333  •  git commit c155726981 ℹ️: Merge 03698582825a7085dd629481c3118d632f3c31d6 into f21034215f2e472129f0e0f19095...
Project opendata
Branch Review AV-2417_remove_contact_form
Run status status check passed Passed #5333
Run duration 04m 13s
Commit git commit c155726981 ℹ️: Merge 03698582825a7085dd629481c3118d632f3c31d6 into f21034215f2e472129f0e0f19095...
Committer Jari Voutilainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

@Zharktas Zharktas merged commit 1cd46be into master Feb 25, 2025
41 checks passed
@Zharktas Zharktas deleted the AV-2417_remove_contact_form branch February 25, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants