AV-2418: Add validate packages feature to syke harvester #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2586 +/- ##
==========================================
- Coverage 27.19% 27.09% -0.11%
==========================================
Files 42 42
Lines 5923 5946 +23
Branches 37 37
==========================================
Hits 1611 1611
- Misses 4312 4335 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opendata
|
||||||||||||||||||||||||||||
| Project |
opendata
|
| Branch Review |
AV-2418_add_validate_packages_to_syke_harvester
|
| Run status |
|
| Run duration | 03m 54s |
| Commit |
|
| Committer | Jari Voutilainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
83
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syke harvester did not have validate packages feature which was implemented in ckan harverster in vrk-kpa/ckanext-harvest@ec4c55c
without it, creating tags might fail on sql level and harvesting crashes or acts weirdly.