Skip to content

Commit c0f1abf

Browse files
authored
Merge pull request #14 from vshn/fix/panic-on-not-found
Fix panic when StatefulSet is not found
2 parents d29f502 + 3b022ef commit c0f1abf

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

controllers/controller.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ func (r *StatefulSetReconciler) Reconcile(ctx context.Context, req ctrl.Request)
3535

3636
sts, err := r.fetchStatefulSet(ctx, req.NamespacedName)
3737
if err != nil {
38-
l.Error(err, "Unable to fetch StatefulSet")
39-
return ctrl.Result{}, err
38+
return ctrl.Result{}, client.IgnoreNotFound(err)
4039
}
4140
if !sts.Resizing() || sts.Failed() {
4241
return ctrl.Result{}, nil

controllers/statefulset.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88

99
appsv1 "k8s.io/api/apps/v1"
1010
"k8s.io/apimachinery/pkg/types"
11-
"sigs.k8s.io/controller-runtime/pkg/client"
1211
"sigs.k8s.io/controller-runtime/pkg/log"
1312

1413
"github.com/vshn/statefulset-resize-controller/statefulset"
@@ -43,7 +42,7 @@ func (r StatefulSetReconciler) fetchStatefulSet(ctx context.Context, namespacedN
4342
old := &appsv1.StatefulSet{}
4443
err := r.Get(ctx, namespacedName, old)
4544
if err != nil {
46-
return nil, client.IgnoreNotFound(err)
45+
return nil, err
4746
}
4847
sts, err := statefulset.NewEntity(old)
4948
if err != nil {

0 commit comments

Comments
 (0)