From e59b10c7db21bfe229aab5c35093644a6af6f7e5 Mon Sep 17 00:00:00 2001 From: Guilherme Carvalho Date: Mon, 4 Dec 2023 13:55:17 -0300 Subject: [PATCH] Add experimental flag to allow stores to disable NextSEO robots (#2140) ## What's the purpose of this pull request? FastStore stores use NextSEO's default robot tags. This PR allows stores to opt-out of the robot tags and write their own. Solves #2139 ## How to test it? Check the deploy preview [of this PR](https://github.com/vtex-sites/starter.store/pull/294) and see that there are no robot tags. ## References [Next SEO](https://github.com/garmeeh/next-seo) --- packages/core/faststore.config.default.js | 1 + packages/core/package.json | 2 +- packages/core/src/pages/_app.tsx | 6 ++++++ yarn.lock | 10 +++++----- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/core/faststore.config.default.js b/packages/core/faststore.config.default.js index 2629687ae3..beec409f08 100644 --- a/packages/core/faststore.config.default.js +++ b/packages/core/faststore.config.default.js @@ -91,5 +91,6 @@ module.exports = { experimental: { cypressVersion: 12, enableCypressExtension: false, + noRobots: false, }, } diff --git a/packages/core/package.json b/packages/core/package.json index 4183dac282..90bbd76c97 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -60,7 +60,7 @@ "include-media": "^1.4.10", "msw": "^0.43.1", "next": "^12.3.1", - "next-seo": "^5.4.0", + "next-seo": "^6.4.0", "nextjs-progressbar": "^0.0.14", "postcss": "^8.4.4", "prettier": "^2.2.0", diff --git a/packages/core/src/pages/_app.tsx b/packages/core/src/pages/_app.tsx index eafae93277..baf6f53fec 100644 --- a/packages/core/src/pages/_app.tsx +++ b/packages/core/src/pages/_app.tsx @@ -11,6 +11,10 @@ import Layout from 'src/Layout' import AnalyticsHandler from 'src/sdk/analytics' import ErrorBoundary from 'src/sdk/error/ErrorBoundary' +import storeConfig from '../../faststore.config' + +import { DefaultSeo } from 'next-seo' + function App({ Component, pageProps }: AppProps) { return ( @@ -20,6 +24,8 @@ function App({ Component, pageProps }: AppProps) { options={{ showSpinner: false }} /> + + diff --git a/yarn.lock b/yarn.lock index 1dbb2eb2db..916cb5947a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14945,16 +14945,16 @@ next-mdx-remote@^4.2.1: vfile "^5.3.0" vfile-matter "^3.0.1" -next-seo@^5.4.0: - version "5.15.0" - resolved "https://registry.yarnpkg.com/next-seo/-/next-seo-5.15.0.tgz#b1a90508599774982909ea44803323c6fb7b50f4" - integrity sha512-LGbcY91yDKGMb7YI+28n3g+RuChUkt6pXNpa8FkfKkEmNiJkeRDEXTnnjVtwT9FmMhG6NH8qwHTelGrlYm9rgg== - next-seo@^6.0.0: version "6.1.0" resolved "https://registry.yarnpkg.com/next-seo/-/next-seo-6.1.0.tgz#b60b06958cc77e7ed56f0a61b2d6cd0afed88ebb" integrity sha512-iMBpFoJsR5zWhguHJvsoBDxDSmdYTHtnVPB1ij+CD0NReQCP78ZxxbdL9qkKIf4oEuZEqZkrjAQLB0bkII7RYA== +next-seo@^6.4.0: + version "6.4.0" + resolved "https://registry.yarnpkg.com/next-seo/-/next-seo-6.4.0.tgz#05a75b8acae881f856eb690b1f66b5e8741aa16e" + integrity sha512-XQFxkOL2hw0YE+P100HbI3EAvcludlHPxuzMgaIjKb7kPK0CvjGvLFjd9hszZFEDc5oiQkGFA8+cuWcnip7eYA== + next-themes@^0.2.1: version "0.2.1" resolved "https://registry.yarnpkg.com/next-themes/-/next-themes-0.2.1.tgz#0c9f128e847979daf6c67f70b38e6b6567856e45"