Skip to content

Commit 6df712e

Browse files
committed
feat(menu): change popover position as designed
1 parent b94ba2d commit 6df712e

File tree

4 files changed

+49
-35
lines changed

4 files changed

+49
-35
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1-
import { MenuProvider } from '@ariakit/react'
1+
import type { MenuProviderProps } from '@ariakit/react'
2+
import { MenuProvider as Provider } from '@ariakit/react'
3+
import React from 'react'
24

3-
export { MenuProvider }
5+
export function MenuProvider(props: MenuProviderProps) {
6+
const { placement = 'bottom-end', ...otherProps } = props
7+
8+
return <Provider placement={placement} {...otherProps} />
9+
}

packages/components/src/menu/stories/menu.stories.tsx

+36-31
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import '../../../dist/styles.min.css'
22
import '../menu.css'
3+
import './style.css'
34
import React from 'react'
45
import {
56
IconCaretDown,
@@ -26,45 +27,49 @@ export default {
2627

2728
export function Default() {
2829
return (
29-
<MenuProvider>
30-
<MenuTrigger>Open</MenuTrigger>
31-
<Menu>
32-
<MenuItem>New Tab</MenuItem>
33-
<MenuItem>New Item</MenuItem>
34-
<MenuSeparator />
35-
<MenuItem>Downloads</MenuItem>
36-
</Menu>
37-
</MenuProvider>
30+
<div className="base-story">
31+
<MenuProvider>
32+
<MenuTrigger>Open</MenuTrigger>
33+
<Menu>
34+
<MenuItem>New Tab</MenuItem>
35+
<MenuItem>New Item</MenuItem>
36+
<MenuSeparator />
37+
<MenuItem>Downloads</MenuItem>
38+
</Menu>
39+
</MenuProvider>
40+
</div>
3841
)
3942
}
4043

4144
export function Composition() {
4245
return (
43-
<MenuProvider>
44-
<MenuTrigger asChild>
45-
<Button>
46-
Open <IconCaretDown />
47-
</Button>
48-
</MenuTrigger>
49-
<Menu asChild>
50-
<div style={{ border: '5px solid red' }}>
51-
<MenuItem>New Tab</MenuItem>
52-
<MenuItem>New Item</MenuItem>
53-
<MenuSeparator />
54-
<MenuItem asChild>
55-
<a href="htpps://vtex.com" target="_blank" rel="noreferrer">
56-
Downloads
57-
</a>
58-
</MenuItem>
59-
</div>
60-
</Menu>
61-
</MenuProvider>
46+
<div className="base-story">
47+
<MenuProvider placement="bottom-end">
48+
<MenuTrigger asChild>
49+
<Button>
50+
Open <IconCaretDown />
51+
</Button>
52+
</MenuTrigger>
53+
<Menu asChild>
54+
<div style={{ border: '5px solid red' }}>
55+
<MenuItem>New Tab</MenuItem>
56+
<MenuItem>New Item</MenuItem>
57+
<MenuSeparator />
58+
<MenuItem asChild>
59+
<a href="htpps://vtex.com" target="_blank" rel="noreferrer">
60+
Downloads
61+
</a>
62+
</MenuItem>
63+
</div>
64+
</Menu>
65+
</MenuProvider>
66+
</div>
6267
)
6368
}
6469

6570
export function MoreActions() {
6671
return (
67-
<Stack>
72+
<Stack className="base-story">
6873
<Stack direction="row" space="5rem">
6974
<MenuProvider>
7075
<MenuTrigger asChild>
@@ -206,7 +211,7 @@ export function MoreActions() {
206211

207212
export function CustomLabel() {
208213
return (
209-
<Stack>
214+
<Stack className="base-story">
210215
<MenuProvider>
211216
<MenuTrigger asChild>
212217
<Button variant="primary">
@@ -239,7 +244,7 @@ export function CustomLabel() {
239244

240245
export function ItemVariants() {
241246
return (
242-
<Stack>
247+
<Stack className="base-story">
243248
<MenuProvider>
244249
<MenuTrigger asChild>
245250
<Button variant="primary">
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
.base-story {
2+
padding: 2rem;
3+
}

packages/next-docs/next-env.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
/// <reference types="next" />
2-
/// <reference types="next/image-types/global" />
1+
// / <reference types="next" />
2+
// / <reference types="next/image-types/global" />
33

44
// NOTE: This file should not be edited
55
// see https://nextjs.org/docs/basic-features/typescript for more information.

0 commit comments

Comments
 (0)