-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[Placeholder]: Clear up situation with assets paths in production for css-loader #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not sure I can follow. Does your pahge live at You "fixed" it by changing it to an empty string, which essentially is the same as changing it to The other solution would be to use change it to So why do we start with an absolute path to begin with? Because many, many apps use vue-Router with But since history mode doesn't work on github pages anyway, your solution is fine for your usecase, I think. Sidenote: This doesn't really have anythign to do with the topic of this issue - it's about other assets path problems. |
Yeah, I'm kind of (ab)using GitHub pages for the time being to host a professional portfolio. The problem with changing it to
Yeah, I bought this up because I wasn't sure if that was likely to screw with other things or if it was an okay thing to do without breaking things..
Oh, it doesn't? Huh. TIL.
Oh, sorry - I thought it was a manifestation of the same issue |
Well, history mode requires some settings on the webserver, which you can't influence o github pages. the normal navigation works, but refrrshing a page will lead to a 404. |
That....kind of makes sense now that I think about it, yeah. |
PR #1230 fixes this issue, by obtaining this data during the install process, which sets the base URL during the build process and then deploys directly to the |
We have had multiple issues like #208 (#563, #552 ) which seem to show that under specific circumstances the paths generated by url-loader/file-loader are wrong.
But to be perfectly honest, I wasn't able to wrap my head around it, especially when trying to thing about how to test the proposed solution of using relative paths under various circumstances:
So If anyone can help shed some light on this and work out a robust solution, I'd be delighted.
The text was updated successfully, but these errors were encountered: