Skip to content

Commit cae86f1

Browse files
committed
ci: only cache binaries when necessary
I find many of the CI minutes are wasted on unnecessary caching
1 parent 487a498 commit cae86f1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: .github/workflows/ci.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,17 @@ jobs:
131131
echo "PLAYWRIGHT_BROWSERS_PATH=$HOME\.cache\playwright-bin" >> $env:GITHUB_ENV
132132
echo "CYPRESS_CACHE_FOLDER=$HOME\.cache\cypress-bin" >> $env:GITHUB_ENV
133133
134-
- name: Cache Cypress binaries
134+
- if: ${{ contains(matrix.flag-for-e2e, '--cypress') }}
135+
name: Cache Cypress binaries
135136
id: cache-cypress
136137
uses: actions/cache@v3
137138
with:
138139
# TODO: avoid snowballing by adding version
139140
key: ${{ runner.os }}-cypress-bin
140141
path: ${{ env.CYPRESS_CACHE_FOLDER }}
141142

142-
- name: Cache Playwright's binary
143+
- if: ${{ contains(matrix.flag-for-e2e, '--playwright') }}
144+
name: Cache Playwright's binary
143145
uses: actions/cache@v3
144146
with:
145147
# Playwright removes unused browsers automatically

0 commit comments

Comments
 (0)