Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the appid and apikey of Algolia reasonable here? #3171

Closed
heygsc opened this issue Feb 8, 2025 · 1 comment
Closed

Is the appid and apikey of Algolia reasonable here? #3171

heygsc opened this issue Feb 8, 2025 · 1 comment

Comments

@heygsc
Copy link
Contributor

heygsc commented Feb 8, 2025

This seems to be a plugin configuration for VitePress, but I didn't see a clear recommendation in the Algolia documentation. It seems more reasonable to inject environment variables?

https://github.com/vuejs/docs/blob/main/.vitepress/config.ts#L724-L725

@brc-dd
Copy link
Member

brc-dd commented Mar 19, 2025

Those can be public. Hardcoding them is fine. Also, makes it easier for contributors to use search functionality locally. Storing them in .env will need to checkout a .env.example and one would need to first copy and fill it.

@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants