Skip to content

Commit 7d257ed

Browse files
committed
feat: enabled experimentalImplicitWrapComponentOptionsWithDefineComponent by default for lang="js"
close #1298
1 parent ef8a061 commit 7d257ed

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

extensions/vscode-vue-language-features/schemas/vue-tsconfig.schema.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
"markdownDescription": "https://github.com/johnsoncodehk/volar/pull/351"
1818
},
1919
"experimentalImplicitWrapComponentOptionsWithDefineComponent": {
20-
"type": "boolean",
20+
"enum": [
21+
true,
22+
false,
23+
"onlyJs"
24+
],
2125
"markdownDescription": "Implicit wrap object literal component options export with `defineComponent()`."
2226
},
2327
"experimentalTemplateCompilerOptions": {

packages/vue-typescript/src/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export interface ITemplateScriptData {
1212

1313
export interface VueCompilerOptions {
1414
experimentalCompatMode?: 2 | 3;
15-
experimentalImplicitWrapComponentOptionsWithDefineComponent?: boolean;
15+
experimentalImplicitWrapComponentOptionsWithDefineComponent?: boolean | 'onlyJs';
1616
experimentalTemplateCompilerOptions?: any;
1717
experimentalTemplateCompilerOptionsRequirePath?: string;
1818
experimentalDisableTemplateSupport?: boolean;

packages/vue-typescript/src/use/useSfcScriptGen.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ export function useSfcScriptGen<T extends 'template' | 'script'>(
4646
return bindTexts;
4747
},
4848
getVueLibraryName(compilerOptions.experimentalCompatMode === 2),
49-
!!compilerOptions.experimentalImplicitWrapComponentOptionsWithDefineComponent,
49+
(compilerOptions.experimentalImplicitWrapComponentOptionsWithDefineComponent ?? 'onlyJs') === 'onlyJs'
50+
? lang.value === 'js' || lang.value === 'jsx'
51+
: !!compilerOptions.experimentalImplicitWrapComponentOptionsWithDefineComponent,
5052
)
5153
);
5254
const file = computed(() => {

0 commit comments

Comments
 (0)