Merge pull request #1703 from fergaldoyle/dev

IE should prefer bound props over static props other than class

Author: yyx990803

package.json

@@ -42,6 +42,7 @@
     "karma-commonjs": "^0.0.13",
     "karma-coverage": "^0.5.0",
     "karma-firefox-launcher": "^0.1.6",
+    "karma-ie-launcher": "^0.2.0",
     "karma-jasmine": "^0.3.6",
     "karma-phantomjs-launcher": "^0.2.1",
     "karma-safari-launcher": "^0.1.1",

src/compiler/compile-props.js

@@ -21,7 +21,7 @@ module.exports = function compileProps (el, propOptions) {
   var props = []
   var names = Object.keys(propOptions)
   var i = names.length
-  var options, name, attr, value, path, parsed, prop, isTitleBinding
+  var options, name, attr, value, path, parsed, prop, hasBinding
   while (i--) {
     name = names[i]
     options = propOptions[name] || empty
@@ -50,16 +50,12 @@ module.exports = function compileProps (el, propOptions) {
       mode: propBindingModes.ONE_WAY
     }
 
-    // IE title issues
-    isTitleBinding = false
-    if (name === 'title' && (el.getAttribute(':title') || el.getAttribute('v-bind:title'))) {
-      isTitleBinding = true
-    }
+    attr = _.hyphenate(name)
+    hasBinding = _.preferBinding && hasBindingAttr(el, attr)
 
     // first check literal version
-    attr = _.hyphenate(name)
     value = prop.raw = _.attr(el, attr)
-    if (value === null || isTitleBinding) {
+    if (value === null || hasBinding) {
       // then check dynamic version
       if ((value = _.getBindAttr(el, attr)) === null) {
         if ((value = _.getBindAttr(el, attr + '.sync')) !== null) {
@@ -119,6 +115,24 @@ module.exports = function compileProps (el, propOptions) {
   return makePropsLinkFn(props)
 }
 
+/**
+ * Check existance of an attribute with binding syntax.
+ *
+ * @param {Element} el
+ * @return {String} attr
+ */
+
+function hasBindingAttr (el, attr) {
+  if (attr === 'class') {
+    return false
+  }
+
+  return (
+    el.hasAttribute(':' + attr) ||
+    el.hasAttribute('v-bind:' + attr)
+  )
+}
+
 /**
  * Build a function that applies props to a vm.
  *

src/util/env.js

@@ -83,3 +83,14 @@ exports.nextTick = (function () {
     timerFunc(nextTickHandler, 0)
   }
 })()
+
+// feature detect browsers (IE) that have trouble
+// with binding syntax on certain attributes
+var div
+var preferBinding = false
+if (inBrowser) {
+  div = document.createElement('div')
+  div.setAttribute(':title', '')
+  preferBinding = div.getAttribute('title') !== null
+}
+exports.preferBinding = preferBinding

test/unit/specs/misc_spec.js

@@ -270,7 +270,7 @@ describe('Misc', function () {
     expect(hasWarned(__, 'Unknown custom element')).toBe(true)
   })
 
-  it('prefer bound title over static title', function (done) {
+  it('prefer bound attributes over static attributes', function (done) {
     var el = document.createElement('div')
     var count = 0
     var expected = [
@@ -289,6 +289,13 @@ describe('Misc', function () {
     }
 
     document.body.appendChild(el)
+    
+    el.setAttribute(':title', '')
+    if(el.getAttribute('title') === null) {
+      // this browser does not need this test
+      done()
+      return
+    }
 
     new Vue({
       el: el,