v-show: skip transition if element is detached (fix #1717)

Author: yyx990803

src/directives/internal/transition.js

@@ -3,7 +3,7 @@ var Transition = require('../../transition/transition')
 
 module.exports = {
 
-  priority: 1000,
+  priority: 1100,
 
   update: function (id, oldId) {
     var el = this.el

src/directives/public/show.js

@@ -12,15 +12,21 @@ module.exports = {
   },
 
   update: function (value) {
-    var el = this.el
-    transition.apply(el, value ? 1 : -1, function () {
+    this.apply(this.el, value)
+    if (this.elseEl) {
+      this.apply(this.elseEl, !value)
+    }
+  },
+
+  apply: function (el, value) {
+    function done () {
       el.style.display = value ? '' : 'none'
-    }, this.vm)
-    var elseEl = this.elseEl
-    if (elseEl) {
-      transition.apply(elseEl, value ? -1 : 1, function () {
-        elseEl.style.display = value ? 'none' : ''
-      }, this.vm)
+    }
+    // do not apply transition if not in doc
+    if (_.inDoc(el)) {
+      transition.apply(el, value ? 1 : -1, done, this.vm)
+    } else {
+      done()
     }
   }
 }

test/unit/specs/directives/public/show_spec.js

@@ -9,13 +9,19 @@ if (_.inBrowser) {
     var el
     beforeEach(function () {
       el = document.createElement('div')
+      document.body.appendChild(el)
       spyOn(transition, 'apply').and.callThrough()
     })
 
+    afterEach(function () {
+      document.body.removeChild(el)
+    })
+
     it('should work', function () {
       var dir = {
         el: el,
         update: def.update,
+        apply: def.apply,
         vm: new Vue()
       }
       dir.update(false)