Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-git): improve contributors info parsing #405

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

username

First, only trust the username from Info[] and the noreply email.

And then,If the provider is github, check if the name meets the rules for a GitHub username; if it does, optimistically consider it as the username; otherwise, set it to empty.

Screenshots

QQ_1741707943686

QQ_1741708011444

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13792335746

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.533%

Totals Coverage Status
Change from base Build 13787772916: 0.0%
Covered Lines: 1358
Relevant Lines: 2059

💛 - Coveralls

@Mister-Hope Mister-Hope enabled auto-merge (squash) March 11, 2025 22:13
@Mister-Hope Mister-Hope merged commit 25fc2c3 into main Mar 11, 2025
34 checks passed
@Mister-Hope Mister-Hope deleted the improve-git-contributors branch March 11, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants