Swap lerna for Turbo v2 (#7180)

* Add turbo cache

* Use newer cache version

* install turbo

* update scripts

* add packageManager as per turbo v2 requirements

* Add turbo.json and fix workspace packages glob

* Use v1 tag

Before this commit, everytime a new gitguardian action version came
out, you had to manually change the version from .e.g 1.26 to 1.27 in
the yml

After this commit, we're using the new feature where gitguardian
updates the v1 tag to the latest v1 release, so we're always
automatically using the latest version

* Rollback to turbo v1

* Allow changesets to create PRs that automatically run their workflows

* Add turbo v2

Author: sethidden

.github/workflows/cd-integrations.yml

@@ -43,5 +43,6 @@ jobs:
         env:
           # If you are running into the problem where PRs created by changesets don't run workflows and are stuck forever,
           # you can create a PR_CREATOR_TOKEN secret. You need to create a fine-grained PAT with the read & write permissions for "Content" and "Pull requests".
+          # Needs access to push to main
           GITHUB_TOKEN: ${{ secrets.PR_CREATOR_TOKEN || secrets.GITHUB_TOKEN }}
           NODE_AUTH_TOKEN: ${{ inputs.enterprise && secrets.VERDACCIO_AUTH_TOKEN || secrets.NPM_RELEASE_TOKEN }}

.github/workflows/ci-integrations.yml

@@ -20,12 +20,10 @@ jobs:
     if: false
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0 # fetch all history so multiple commits can be scanned
-      - name: GitGuardian scan
-        uses: GitGuardian/ggshield-action@v1.27.0
+      - uses: GitGuardian/ggshield-action@v1
         with:
           args: -v
         env:
@@ -77,11 +75,15 @@ jobs:
         with:
           projectPath: ${{ github.workspace }}
 
-      - run: yarn build
-
-      - run: yarn lint
+      - name: Cache turbo build setup
+        uses: actions/cache@v4
+        with:
+          path: .turbo
+          key: ${{ runner.os }}-turbo-${{ github.sha }}
+          restore-keys: |
+            ${{ runner.os }}-turbo-
 
-      - run: yarn test
+      - run: yarn ci
 
       - name: Upload test coverage
         uses: actions/upload-artifact@v4
@@ -91,6 +93,3 @@ jobs:
           path: |
             coverage
             packages/**/coverage
-
-      - name: Lint project
-        run: yarn lint

lerna.json

@@ -3,11 +3,12 @@
   "private": true,
   "scripts": {
     "prepare": "husky install",
-    "build": "lerna run build",
-    "test": "lerna run test",
-    "test:unit": "lerna run test:unit",
-    "test:integration": "lerna run test:integration",
-    "lint": "lerna run lint",
+    "build": "turbo run build",
+    "test": "turbo run test",
+    "test:unit": "turbo run test:unit",
+    "test:integration": "turbo run test:integration",
+    "lint": "turbo run lint",
+    "ci": "turbo run build test:unit test:integration lint",
     "changesets:version": "yarn changeset version && YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install && yarn prepare:docs",
     "changesets:publish": "yarn build && yarn changeset publish",
     "prepare:docs": "cd docs && yarn install && yarn api-extract && yarn add-changelogs",
@@ -26,23 +27,24 @@
     "cross-env": "^6.0.3",
     "husky": "^8.0.3",
     "jest": "^27.0.6",
-    "lerna": "^6.6.2",
     "lint-staged": "^13.2.2",
     "rimraf": "^5.0.0",
     "rollup": "^2.59.0",
     "ts-jest": "^27.0.3",
     "ts-node": "^8.4.1",
     "tslib": "^2.1.0",
+    "turbo": "^2.0.10-canary.1",
     "typescript": "^5",
     "webpack-bundle-analyzer": "^3.5.2"
   },
   "workspaces": {
     "packages": [
-      "packages/!(storefront)",
+      "packages/*",
       "engineering-toolkit/*"
     ]
   },
   "engines": {
-    "node": ">=12.x"
-  }
+    "node": ">=18"
+  },
+  "packageManager": "yarn@1.22.22"
 }

package.json

@@ -0,0 +1,37 @@
+{
+  "$schema": "https://turbo.build/schema.json",
+  "tasks": {
+    "build": {
+      "dependsOn": ["^build"],
+      "outputs": ["lib/**", "server/**"]
+    },
+    "test:unit": {
+      // Sometimes in unit tests of SDK we refer to the "types" package of the integration
+      // so this means the dependencies of the packages need to be built
+      "dependsOn": ["^build"],
+      "inputs": ["src/**/*.ts", "__tests__/unit/**/*.ts"],
+      "outputs": ["coverage/**"]
+    },
+    "test:integration": {
+      // Similarly to unit tests, people just freely import stuff from subdeps :(
+      "dependsOn": ["^build"],
+      "inputs": ["src/**/*.ts", "__tests__/integration/**/*.ts"],
+      "outputs": ["coverage/**"],
+      "env": ["TEST_*"]
+    },
+    "lint": {
+      // ESLint fails the 'is this import statement resolveable?' rule if the
+      // dependencies of some package aren't built
+      "dependsOn": ["^build"]
+    },
+    "sync-changelog": {
+      // Changelog is just a text file, just make sure to call npx changesets:version beforehand
+      "dependsOn": []
+    },
+    "sync-api": {
+      // api-extractor expects a ./lib/api-extractor-data.d.ts file to exist
+      // so the each package needs to be built before api extraction
+      "dependsOn": ["build"]
+    }
+  }
+}