Improve code styling and quality

Author: w3bdesign

5 Kyu/directions-reduction.php

@@ -42,8 +42,8 @@
 */
 
 function dirReduc($array)
-{ 
-    $stack = [];    
+{
+    $stack = [];
     $opposite = array(
         "NORTH" => "SOUTH",
         "EAST" => "WEST",
@@ -52,10 +52,10 @@ function dirReduc($array)
     );
     $array_count = count($array);
     $index = 0;
-    while ($index < $array_count){
-        if($opposite[$array[$index]] == end($stack)) {
+    while ($index < $array_count) {
+        if ($opposite[$array[$index]] == end($stack)) {
             array_pop($stack);
-        }           
+        }
         array_push($stack, $array[$index]);
         $index++;
     }
@@ -71,8 +71,8 @@ function altdirReduc($array)
     foreach ($array as $value) {
         if (end($stack) == $ops[$value]) {
             array_pop($stack);
-        } 
-        $stack[] = $value;        
+        }
+        $stack[] = $value;
     }
     return $stack;
 }

6 Kyu/find-the-odd-int.php

@@ -13,23 +13,19 @@
  */
 function findIt(array $arr) : int
 {
-    
-    $count = 0; 
+    $count = 0;
     $arrCount = count($arr);
-    for ($i = 0;  $i < $arrCount; $i++)  
-    { 
-          
-        for ($j = 0; $j < $arrCount; $j++) 
-        { 
-            if ($arr[$i] == $arr[$j]) { 
+    for ($i = 0;  $i < $arrCount; $i++) {
+        for ($j = 0; $j < $arrCount; $j++) {
+            if ($arr[$i] == $arr[$j]) {
                 $count++;
-            } 
-        } 
-        if ($count % 2 != 0) { 
+            }
+        }
+        if ($count % 2 != 0) {
             return $arr[$i];
-        } 
-    } 
-    return -1; 
+        }
+    }
+    return -1;
 }
 
 // Alternate solution:
@@ -48,5 +44,5 @@ function altfindIt(array $seq) : mixed
             return $key;
         }
     }
-    return -1; 
+    return -1;
 }

6 Kyu/multiples-of-3-or-5.php

@@ -10,9 +10,8 @@
 function solution($number)
 {
     $sum = 0;
-    for ( $i = 3; $i < $number; $i++) {
-
-        if ($i % 3 === 0 || $i % 5 === 0) {   
+    for ($i = 3; $i < $number; $i++) {
+        if ($i % 3 === 0 || $i % 5 === 0) {
             $sum += $i;
         }
     }
@@ -25,9 +24,10 @@ function altSolution($number)
 {
     return array_sum(
         array_filter(
-            range(1, $number-1), function ($item) {
+            range(1, $number-1),
+            function ($item) {
                 return $item % 3 == 0 || $item % 5 == 0;
             }
         )
     );
-}
+}

6 Kyu/persistent-bugger.php

@@ -27,13 +27,15 @@ function persistence(int $num): int
 
     if ($numArrayCount > 1) {
         for ($i = 0; $i < $numArrayCount; $i++) {
-            $total *= $numArray[$i];      
+            $total *= $numArray[$i];
         }
         $count++;
         if (strlen($total) > 1) {
             return $count + persistence($total);
-        }  return $count;
-    }  return $count;    
+        }
+        return $count;
+    }
+    return $count;
 }
 
 // Alternate solution - array_product multiplies all values in the array, so we wont need to use a loop
@@ -55,4 +57,4 @@ function altPersistence(int $num): int
     }
 
     return $count;
-}
+}

7 Kyu/descending-order.php

@@ -18,8 +18,8 @@
  */
 function descendingOrder(int $number): int
 {
-  $number = (int)$number;
-  $arrayNumber = str_split($number);
-  arsort($arrayNumber);
-  return (int) implode($arrayNumber);
+    $number = (int)$number;
+    $arrayNumber = str_split($number);
+    arsort($arrayNumber);
+    return (int) implode($arrayNumber);
 }

7 Kyu/get-the-middle-character.php

@@ -23,28 +23,25 @@
 
 function getMiddle($text)
 {
-
     $length = strlen($text);
     $middle = $length / 2;
 
-    if($length % 2 == 0) {
+    if ($length % 2 == 0) {
         $returnedText = $text[$middle-1];
         $returnedText.= $text[$middle];
     }
     $returnedText.= $text[$middle];
     return $returnedText;
-
 }
 
 
 // Alternative method:
 
-function getMiddle($text)
+function altgetMiddle($text)
 {
     $len = strlen($text);
     if ($len % 2 === 0) {
         return substr($text, $len / 2 - 1, 2);
     }
     return substr($text, $len / 2, 1);
 }
-?>

7 Kyu/growth-of-a-population.php

@@ -2,10 +2,10 @@
 /*
 In a small town the population is p0 = 1000 at the beginning of a year. The population regularly increases by 2 percent per year and moreover 50 new inhabitants per year come to live in the town. How many years does the town need to see its population greater or equal to p = 1200 inhabitants?
 
-At the end of the first year there will be: 
+At the end of the first year there will be:
 1000 + 1000 * 0.02 + 50 => 1070 inhabitants
 
-At the end of the 2nd year there will be: 
+At the end of the 2nd year there will be:
 1070 + 1070 * 0.02 + 50 => 1141 inhabitants (number of inhabitants is an integer)
 
 At the end of the 3rd year there will be:
@@ -32,14 +32,13 @@ function nbYear($startpeople, $percent, $aug, $endpeople)
 {
     $counter = 0;
     for ($counter; $startpeople < $endpeople; $counter++) {
-        $startpeople = $startpeople * (1 + $percent / 100) + $aug ;    
+        $startpeople = $startpeople * (1 + $percent / 100) + $aug ;
     }
-      return $counter;
+    return $counter;
 }
 
 // Alternate solution with ternary:
-function nbYear($startpeople, $percent, $aug, $endpeople)
+function altnbYear($startpeople, $percent, $aug, $endpeople)
 {
-    return $startpeople >= $endpeople ? 0 : 1 + nbYear((int)$startpeople * (1+$percent/100) + $aug, $percent, $aug, $endpeople);   
+    return $startpeople >= $endpeople ? 0 : 1 + nbYear((int)$startpeople * (1+$percent/100) + $aug, $percent, $aug, $endpeople);
 }
-?>

7 Kyu/highest-and-lowest.php

@@ -16,18 +16,17 @@
 */
 
 function highAndLow($numbers)
-{  
+{
     $splitNumbers = explode(" ", $numbers);
     $highestNumber = max($splitNumbers);
     $lowestNumber = min($splitNumbers);
-    return "$highestNumber $lowestNumber";  
+    return "$highestNumber $lowestNumber";
 }
 
 // Alternate solution
 
-function highAndLow($numbers)
-{  
-    $splitNumbers = explode(" ", $numbers);    
-    return max($splitNumbers) . " " . min($splitNumbers);  
+function althighAndLow($numbers)
+{
+    $splitNumbers = explode(" ", $numbers);
+    return max($splitNumbers) . " " . min($splitNumbers);
 }
-?>

7 Kyu/two-to-one.php

@@ -20,16 +20,14 @@ function longest($a, $b)
     $arrayString = str_split($combinedString);
     $uniqueString = array_unique($arrayString);
     sort($uniqueString);
-    return implode($uniqueString);      
+    return implode($uniqueString);
 }
 
 // Alternate solution
 
-function longest($a, $b)
+function altlongest($a, $b)
 {
     $chars = array_unique(str_split($a . $b));
     sort($chars);
     return implode('', $chars);
 }
-
-?>

7 Kyu/vowel-count.php

@@ -9,8 +9,7 @@
 
 function getCount($str)
 {
-    // Use regex to get the count 
+    // Use regex to get the count
     //return preg_match_all('/[aeiou]/i', $str, $matches);
     return preg_match_all('/[aeiou]/i', $str);
 }
-?>