Skip to content

[css-borders-4] Remove / in corner-*-shape grammars #11650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cdoublev opened this issue Feb 4, 2025 · 1 comment · Fixed by #11651
Closed

[css-borders-4] Remove / in corner-*-shape grammars #11650

cdoublev opened this issue Feb 4, 2025 · 1 comment · Fixed by #11651
Labels
css-borders-4

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Feb 4, 2025 •
edited
Loading

The grammar of corner-*-shape shorthands requires using / to separate horizontal/vertical radii.

Name: corner-shape
Value: <corner-shape-value>{1,2} [ / <corner-shape-value>{1,2} ]?

Name: corner-top-shape, ...
Value: <corner-shape-value> [ / <corner-shape-value> ]

The corner-*-shape shorthands set the two corner-*-*-shape longhand properties of the related side. If values are given before and after the slash, then the values before the slash set the horizontal radius and the values after the slash set the vertical radius.

(nit: the second <corner-shape-value> in corner-<side>-shape should probably be optional).

But there is no horizontal/vertical definition of a corner shape like with border-radius. Is it an oversight? If so, I guess they should follow the same rules than margin, padding, right?

(edit, clarification) The canonical order of corner-shape longhands would be corner-top-left-shape, corner-top-right-shape, corner-bottom-right-shape, corner-bottom-left-shape.
noamr added a commit to noamr/csswg-drafts that referenced this issue Feb 4, 2025
@noamr
[css-borders-4] Remove the corner-*-shape variant
cca3994 
This variant makes sense for border-radius but not for corner-shape,
as corner-shapes have only one value.

Closes w3c#11650
@noamr noamr mentioned this issue Feb 4, 2025
Merged
@noamr
Copy link
Collaborator

noamr commented Feb 4, 2025

You're right, it's an oversight. #11651

@noamr noamr closed this as completed in 7ffdc91 Feb 4, 2025
@cdoublev cdoublev mentioned this issue Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-borders-4
Projects
None yet
Milestone
No milestone
2 participants
@noamr @cdoublev