Skip to content

Commit d0846f9

Browse files
dontcallmedomdontcallmedom
committed
Add styling for related issues box
also move keyboard shortcut descriptions out of the way
1 parent bff45d0 commit d0846f9

10 files changed

+40
-26
lines changed

‎_includes/related-issues/ay_tensorflow.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/63'>#63 WebGL garbage collection</a></li></ul>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/63'>#63 WebGL garbage collection</a></li></ul></div>

‎_includes/related-issues/dhm-web-platform-overview.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul></div>

‎_includes/related-issues/jb_model.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li>
2-
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/74'>#74 ML Model format</a></li></ul>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li>
2+
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/74'>#74 ML Model format</a></li></ul></div>

‎_includes/related-issues/jm_tensorflowjs.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/62'>#62 Applicability to non-browser JS environments</a></li>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/62'>#62 Applicability to non-browser JS environments</a></li>
22
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/64'>#64 Support for Float16 in JS & WASM environments</a></li>
33
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/66'>#66 WebGPU fitness for ML frameworks</a></li>
4-
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/67'>#67 Protecting ML models</a></li></ul>
4+
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/67'>#67 Protecting ML models</a></li></ul></div>

‎_includes/related-issues/mw-androidnn.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul></div>

‎_includes/related-issues/nh_webnn.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/68'>#68 Progressive Enhancement / Graceful degradation</a></li></ul></div>

‎_includes/related-issues/sm_architecture.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/62'>#62 Applicability to non-browser JS environments</a></li>
1+
<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul><li><a href='https://github.com/w3c/machine-learning-workshop/issues/62'>#62 Applicability to non-browser JS environments</a></li>
22
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/72'>#72 Permission model for Machine Learning APIs</a></li>
33
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/73'>#73 JS Operator overloading for Machine Learning</a></li>
4-
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/74'>#74 ML Model format</a></li></ul>
4+
<li><a href='https://github.com/w3c/machine-learning-workshop/issues/74'>#74 ML Model format</a></li></ul></div>

‎_layouts/talk.html

+15-14
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,6 @@ <h2>{{page.title}} - by {{page.author}}{% if page.affiliation %} ({{page.affilia
5252
{% assign path = "../" %}
5353
<main>
5454
{% include related-issues/{{shortname}}.html %}
55-
<details>
56-
<summary>Keyboard shortcuts in the video player</summary>
57-
<ul>
58-
<li>Play/pause: <kbd>space</kbd>
59-
</li><li>Increase volume: <kbd>up arrow</kbd>
60-
</li><li>Decrease volume: <kbd>down arrow</kbd>
61-
</li><li>Seek forward: <kbd>right arrow</kbd>
62-
</li><li>Seek backward: <kbd>left arrow</kbd>
63-
</li><li>Captions on/off: <kbd>C</kbd>
64-
</li><li>Fullscreen on/off: <kbd>F</kbd>
65-
</li><li>Mute/unmute: <kbd>M</kbd>
66-
</li><li>Seek percent: <kbd>0-9</kbd>
67-
</li></ul>
68-
</details>
6955
<form id="form">
7056
{% if page.slidesurl %}
7157
<input type="checkbox" name="sync" id="sync"><label for="sync" class="button">Sync video and hide transcript
@@ -112,6 +98,21 @@ <h2>{{page.title}} - by {{page.author}}{% if page.affiliation %} ({{page.affilia
11298
<h3>Transcript</h3>
11399
{% include transcripts/{{shortname}}.html %}
114100
{% endif %}
101+
<details>
102+
<summary>Keyboard shortcuts in the video player</summary>
103+
<ul>
104+
<li>Play/pause: <kbd>space</kbd>
105+
</li><li>Increase volume: <kbd>up arrow</kbd>
106+
</li><li>Decrease volume: <kbd>down arrow</kbd>
107+
</li><li>Seek forward: <kbd>right arrow</kbd>
108+
</li><li>Seek backward: <kbd>left arrow</kbd>
109+
</li><li>Captions on/off: <kbd>C</kbd>
110+
</li><li>Fullscreen on/off: <kbd>F</kbd>
111+
</li><li>Mute/unmute: <kbd>M</kbd>
112+
</li><li>Seek percent: <kbd>0-9</kbd>
113+
</li></ul>
114+
</details>
115+
115116
</div><!-- id=player -->
116117
{% include horizontal-nav.html %}
117118
</form>

‎_tools/extract-issues.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ const toSlug = title => title.replace(/([A-Z])/g, s => s.toLowerCase())
1616
let htmlIssueList = ghIssues.filter(i => i.body.includes(url)).sort((a, b) => a.number - b.number)
1717
.map(i => `<li><a href='${i.html_url}'>#${i.number} ${i.title}</a></li>`).join('\n');
1818
if (htmlIssueList !== "") {
19-
content = "<p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul>";
19+
content = "<div class=related><p>Related conversations on <a href='https://github.com/w3c/machine-learning-workshop/issues'>GitHub</a>:</p><ul>";
2020
content += htmlIssueList;
21-
content += "</ul>";
21+
content += "</ul></div>";
2222
}
2323
fs.writeFileSync("_includes/related-issues/" + shortname + ".html", content, {encoding: "utf-8"});
2424
}

‎style.css

+13
Original file line numberDiff line numberDiff line change
@@ -696,3 +696,16 @@ img.tn {
696696
vertical-align:middle;
697697
padding-right:.5em;
698698
}
699+
700+
div.related {
701+
background-color: #C2CDCF;
702+
border-radius: .6em;
703+
padding: 0.5em;
704+
}
705+
div.related p {
706+
margin-bottom: 0;
707+
}
708+
div.related ul {
709+
margin-top: 0;
710+
margin-left: 1em;
711+
}

0 commit comments

Comments
 (0)