Skip to content

Commit 13750ad

Browse files
authored
Ensure that subdomain policies are only for DNS. (#144)
This CL moves the subdomain check -- which is supposed to ensure that only DNS errors are reported for subdomains -- before the step which can downgrade reports, since that step can change some reports into DNS reports, even they were not originally. Closes: #141
1 parent 09c74af commit 13750ad

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

index.html

+16-8
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,22 @@ <h2>Extract response headers</h2>
11361136
</dl>
11371137
</li>
11381138

1139+
<li>
1140+
If <var>origin</var> is not equal to <var>policy</var>'s <a
1141+
data-lt="policy origin">origin</a>, <var>policy</var>'s
1142+
<a>subdomains</a> flag is <code>include</code>, and <var>report
1143+
body</var>'s <code>phase</code> property is not <code>dns</code>,
1144+
return null.
1145+
1146+
<p class="note">
1147+
This step ensures that <a data-lt="subdomains">subdomain</a> <a>NEL
1148+
policies</a> can only be used to generate reports about subdomains of
1149+
the <a>policy origin</a> during the <a>DNS resolution</a> phase of a
1150+
<a>request</a>. See <a href="#privacy-considerations"></a> for more
1151+
details.
1152+
</p>
1153+
</li>
1154+
11391155
<li>
11401156
If <var>report body</var>'s <code>phase</code> property is not
11411157
<code>dns</code>, and <var>report body</var>'s <code>server_ip</code>
@@ -1177,14 +1193,6 @@ <h2>Extract response headers</h2>
11771193
</p>
11781194
</li>
11791195

1180-
<li>
1181-
If <var>origin</var> is not equal to <var>policy</var>'s <a
1182-
data-lt="policy origin">origin</a>, <var>policy</var>'s
1183-
<a>subdomains</a> flag is <code>include</code>, and <var>report
1184-
body</var>'s <code>phase</code> property is not <code>dns</code>,
1185-
return null.
1186-
</li>
1187-
11881196
<li>
11891197
Return <var>report body</var> and <var>policy</var>.
11901198
</li>

0 commit comments

Comments
 (0)