Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate definitions #115

Open
jyasskin opened this issue Jul 3, 2019 · 3 comments
Open

Disambiguate definitions #115

jyasskin opened this issue Jul 3, 2019 · 3 comments

Comments

@jyasskin
Copy link
Member

jyasskin commented Jul 3, 2019

Both Fetch and Network Error Logging define "network error", in different ways. NEL's should probably be spelled differently.

NEL also defines a "type" for network errors, but ought to scope it with data-dfn-for to avoid colliding with all the other types out there.

@igrigorik
Copy link
Member

Hmm, yeah that makes sense, we do have different definitions.

@dcreager do you have bandwidth to tackle this one?

@clelland
Copy link
Contributor

It would sound better, I think, if Fetch's concept were to be spelled "network error response", as it really is a response, rather than being the error condition itself. NEL tries to report on the actual error.

Alternately, if it's not possible to change that, then maybe NEL should rename network error -> network error condition

@jyasskin
Copy link
Member Author

Given how widely Fetch's definition could be used, and how difficult it is to track down all the uses (speced/bikeshed#672), this spec probably can't get around needing to rename "network error" for the medium term, even if Fetch also renames it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants