Skip to content

Commit c4962df

Browse files
[Spec] Rename rp --> rpId in CollectedClientAdditionalPaymentData (#198)
To align with WebAuthn, we should use the term rpId here. This is a breaking change, but implementations can mitigate the breakage by continuing to include the old 'rp' name going forwards. See #191 Test changes: web-platform-tests/wpt#35602 Implementation bugs: Chrome: https://crbug.com/1356224 Safari: N/A Firefox: N/A
1 parent fcbc77d commit c4962df

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

spec.bs

+12-8
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ The [=steps to respond to a payment request=] for this payment method, for a giv
770770

771771
: {{AuthenticationExtensionsPaymentInputs/isPayment}}
772772
:: The boolean value `true`.
773-
: {{AuthenticationExtensionsPaymentInputs/rp}}
773+
: {{AuthenticationExtensionsPaymentInputs/rpId}}
774774
:: |data|["{{SecurePaymentConfirmationRequest/rpId}}"]
775775
: {{AuthenticationExtensionsPaymentInputs/topOrigin}}
776776
:: |topOrigin|
@@ -872,7 +872,7 @@ directly; for authentication the extension can only be accessed via
872872
boolean isPayment;
873873

874874
// Only used for authentication.
875-
USVString rp;
875+
USVString rpId;
876876
USVString topOrigin;
877877
DOMString payeeName;
878878
USVString payeeOrigin;
@@ -887,7 +887,7 @@ directly; for authentication the extension can only be accessed via
887887

888888
<div class="note">**TODO**: Find a better way to do this. Needed currently because other members are auth-time only.</div>
889889

890-
: <dfn>rp</dfn> member
890+
: <dfn>rpId</dfn> member
891891
:: The [=Relying Party=] id of the credential(s) being used. Only used at authentication time; not registration.
892892

893893
: <dfn>topOrigin</dfn> member
@@ -989,8 +989,8 @@ directly; for authentication the extension can only be accessed via
989989
1. {{CollectedClientPaymentData/payment}} set to a new
990990
{{CollectedClientAdditionalPaymentData}} whose fields are:
991991

992-
: {{CollectedClientAdditionalPaymentData/rp}}
993-
:: |extension_inputs|["{{AuthenticationExtensionsPaymentInputs/rp}}"]
992+
: {{CollectedClientAdditionalPaymentData/rpId}}
993+
:: |extension_inputs|["{{AuthenticationExtensionsPaymentInputs/rpId}}"]
994994
: {{CollectedClientAdditionalPaymentData/topOrigin}}
995995
:: |extension_inputs|["{{AuthenticationExtensionsPaymentInputs/topOrigin}}"]
996996
: {{CollectedClientAdditionalPaymentData/payeeName}}
@@ -1036,7 +1036,7 @@ The {{CollectedClientPaymentData}} dictionary inherits from
10361036

10371037
<xmp class="idl">
10381038
dictionary CollectedClientAdditionalPaymentData {
1039-
required USVString rp;
1039+
required USVString rpId;
10401040
required USVString topOrigin;
10411041
DOMString payeeName;
10421042
USVString payeeOrigin;
@@ -1049,9 +1049,13 @@ The {{CollectedClientAdditionalPaymentData}} dictionary contains the following
10491049
fields:
10501050

10511051
<dl dfn-type="dict-member" dfn-for="CollectedClientAdditionalPaymentData">
1052-
: <dfn>rp</dfn> member
1052+
: <dfn>rpId</dfn> member
10531053
:: The id of the [=Relying Party=] that created the credential.
10541054

1055+
NOTE: For historical reasons, some implementations may additionally
1056+
include this parameter with the name `rp`. The values of `rp` and
1057+
`rpId` must be the same if both are present.
1058+
10551059
: <dfn>topOrigin</dfn> member
10561060
:: The origin of the top level context that requested to sign the transaction details.
10571061

@@ -1173,7 +1177,7 @@ Confirmation, the [=Relying Party=] MUST proceed as follows:
11731177

11741178
1. After step 13, insert the following steps:
11751179

1176-
* Verify that the value of |C|["{{CollectedClientPaymentData/payment}}"]["{{CollectedClientAdditionalPaymentData/rp}}"]
1180+
* Verify that the value of |C|["{{CollectedClientPaymentData/payment}}"]["{{CollectedClientAdditionalPaymentData/rpId}}"]
11771181
matches the [=Relying Party=]'s origin.
11781182

11791183
* Verify that the value of |C|["{{CollectedClientPaymentData/payment}}"]["{{CollectedClientAdditionalPaymentData/topOrigin}}"]

0 commit comments

Comments
 (0)