Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validation algorithm check size of bitstring? #87

Closed
andresuribe87 opened this issue Sep 15, 2023 · 2 comments
Closed

Should validation algorithm check size of bitstring? #87

andresuribe87 opened this issue Sep 15, 2023 · 2 comments
Assignees
@msporny
Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists

Comments

@andresuribe87
Copy link
Contributor

The section in https://w3c.github.io/vc-status-list-2021/#validate-algorithm does not mention checking the minimum bitstring size.

Suggestion is that validation should fail when the size of the bitstring is below the minimum of 16KB.
@msporny msporny added the before-CR This issue needs to be resolved before the Candidate Recommendation phase. label Sep 15, 2023
@msporny msporny self-assigned this Sep 15, 2023
@msporny msporny mentioned this issue Dec 29, 2023
Merged
@msporny
Copy link
Member

msporny commented Dec 29, 2023

PR #115 has been raised to address this issue. This issue will be closed once PR #115 has been merged.

@msporny
Copy link
Member

msporny commented Jan 13, 2024

PR #115 has been merged, closing.

@msporny msporny closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @andresuribe87