-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Tip] Design tip no1 - Example #744
Comments
If this is really important than I suggest we make this part of the caption - so, instead of just "Insufficient" we could write "Insufficient - light grey text on white background" or so. I personally don't think it is important what the specific colors are, I never actually noticed them - just the fact the contrast is not sufficient was sufficient information for me to get the point of the tip. |
As I am looking into the next few tips, something else jumped at me. I'm not comfortable using
I suggest we build our examples using the following structure:
Where the content of the Previous comments about making the examples more screen reader friendly still apply. @yatil - Would you mind weighing on on this please, as I'm not 100% familiar with best practices using figure/figcaption. The current structure doesn't fail the validator, but it looks sloppy to me. |
The figcaption describes the other content. In the case of the example above it means that the svg belongs go the insufficient label, that’s why it has an aria-hidden. I think it belongs to the description as it is an icon for the insufficient text. This way it can also be styled as a head for the content. So my vote would be to keep as is, tbh. |
Based on @nitedog's comment then I suggest we make the following changes.
|
Ah, research ;-) Will you send in a pull request? (If you don’t know what that is or how to do it, I’m happy to help 😀) |
@yatil I could definitely use your help to do that. Actually, I would LOVE to do it myself (with your support, of course), as opposed to just delegate it to you. :) |
Reference: http://w3c.github.io/wai-quick-start/designing.html#provide-sufficient-contrast-between-foreground-and-background
I suggest we add additional information for screen reader users to understand the examples better. For example, the
<figcaption>
text for the insufficient example currently reads:I suggest we provide additional context:
Likewise, the other example for sufficient contrast currently reads:
I suggest we provide additional context:
Where "hidden-accessible" would refer to the following CSS rules:
The text was updated successfully, but these errors were encountered: