Skip to content

Commit 2f5ba1a

Browse files
clarify session.subscribe and session.unsubscribe
1 parent bb3f568 commit 2f5ba1a

File tree

1 file changed

+32
-20
lines changed

1 file changed

+32
-20
lines changed

index.bs

Lines changed: 32 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1506,8 +1506,8 @@ session.SystemProxyConfiguration = (
15061506

15071507
<pre class="cddl remote-cddl">
15081508
session.SubscriptionRequest = {
1509-
events: [*text],
1510-
? contexts: [*browsingContext.BrowsingContext],
1509+
events: [+text],
1510+
? contexts: [+browsingContext.BrowsingContext],
15111511
}
15121512
</pre>
15131513

@@ -1695,8 +1695,8 @@ Issue: This needs to be generalized to work with realms too
16951695
<dd>
16961696
<pre class="cddl remote-cddl">
16971697
session.Subscribe = (
1698-
method: "session.subscribe",
1699-
params: session.SubscriptionRequest
1698+
method: "session.subscribe",
1699+
params: session.SubscriptionRequest
17001700
)
17011701
</pre>
17021702
</dd>
@@ -1711,14 +1711,20 @@ Issue: This needs to be generalized to work with realms too
17111711
<div algorithm="remote end steps for session.subscribe">
17121712
The [=remote end steps=] with |session| and |command parameters| are:
17131713

1714-
1. Let the |list of event names| be the value of the <code>events</code> field of
1715-
|command parameters|
1714+
1. Let the |set of event names| be empty [=set=].
17161715

1717-
1. Let the |list of contexts| be the value of the <code>contexts</code>
1718-
field of |command parameters| if it is present or null if it isn't.
1716+
1. For each |event| of <code>command parameters</code>["events"], append |event| to |set of event names|.
1717+
1718+
1. Let |set of contexts| be null.
1719+
1720+
1. If the value of the <code>contexts</code> field of |command parameters| is not null.
1721+
1722+
1. Set |set of contexts| to empty [=set=].
1723+
1724+
1. For each |event| of <code>command parameters</code>["contexts"], append |event| to |set of contexts|.
17191725

17201726
1. Let |enabled events| be the result of [=trying=] to [=update the event map=]
1721-
with |session|, |list of event names| , |list of contexts| and
1727+
with |session|, |set of event names| , |set of contexts| and
17221728
enabled true.
17231729

17241730
1. Let |subscribe step events| be a new [=/map=].
@@ -1761,12 +1767,12 @@ Issue: This needs to be generalised to work with realms too
17611767
<dl>
17621768
<dt>Command Type</dt>
17631769
<dd>
1764-
<pre class="cddl remote-cddl">
1765-
session.Unsubscribe = (
1766-
method: "session.unsubscribe",
1767-
params: session.SubscriptionRequest
1768-
)
1769-
</pre>
1770+
<pre class="cddl remote-cddl">
1771+
session.Unsubscribe = (
1772+
method: "session.unsubscribe",
1773+
params: session.SubscriptionRequest
1774+
)
1775+
</pre>
17701776
</dd>
17711777
<dt>Result Type</dt>
17721778
<dd>
@@ -1779,14 +1785,20 @@ Issue: This needs to be generalised to work with realms too
17791785
<div algorithm="remote end steps for session.unsubscribe">
17801786
The [=remote end steps=] with |session| and |command parameters| are:
17811787

1782-
1. Let the |list of event names| be the value of the <code>events</code> field of
1783-
|command parameters|.
1788+
1. Let the |set of event names| be empty [=set=].
1789+
1790+
1. For each |event| of <code>command parameters</code>["events"], append |event| to |set of event names|.
1791+
1792+
1. Let |set of contexts| be null.
1793+
1794+
1. If the value of the <code>contexts</code> field of |command parameters| is not null.
1795+
1796+
1. Set |set of contexts| to empty [=set=].
17841797

1785-
1. Let the |list of contexts| be the value of the <code>contexts</code>
1786-
field of |command parameters| if it is present or null if it isn't.
1798+
1. For each |event| of <code>command parameters</code>["contexts"], append |event| to |set of contexts|.
17871799

17881800
1. [=Try=] to [=update the event map=] with |session|,
1789-
|list of event names|, |list of contexts| and enabled false.
1801+
|set of event names|, |list of contexts| and enabled false.
17901802

17911803
1. Return [=success=] with data null.
17921804

0 commit comments

Comments
 (0)