Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New downloader makes logs harder to read #2690

Open
Mieekaserra opened this issue Jan 23, 2025 · 0 comments
Open

New downloader makes logs harder to read #2690

Mieekaserra opened this issue Jan 23, 2025 · 0 comments

Comments

@Mieekaserra
Copy link

Mieekaserra commented Jan 23, 2025

Describe the bug

Since switching to the new downloader, logs have become harder to read.

We can no longer tell if a download failed or succeeded (or why it failed) since now all it says in the log is something like this

Finished downloading Vtaw Wardrobe 8 Materials 2K-61541-1-0-1655924128.7z. Hash: CPto+mHt0i4=; Size: 4.6GB/4.6GB

Then we are getting the following error in the log, it does not tell you which file has failed has checked . I've attached an example with several fails. But i see this several times a day in support.

00:00:34.101 [ERROR] (Wabbajack.Installer.StandardInstaller) Downloaded hash AAAAAAAAAAA= does not match expected hash: rXDEtl7gdOU=
00:00:37.257 [FATAL] (Wabbajack.Downloaders.DownloadDispatcher) While finding mirror for G+V5izfMPy0=|System.NullReferenceException: Object reference not set to an instance of an object.
   at Wabbajack.Downloaders.WabbajackCDNDownloader.Download(Archive archive, WabbajackCDN state, AbsolutePath destination, IJob job, CancellationToken token) in c:\oss\wabbajack\Wabbajack.Downloaders.WabbajackCDN\WabbajackCDNDownloader.cs:line 83
   at Wabbajack.Downloaders.WabbajackCDNDownloader.Download(Archive archive, WabbajackCDN state, AbsolutePath destination, IJob job, CancellationToken token) in c:\oss\wabbajack\Wabbajack.Downloaders.WabbajackCDN\WabbajackCDNDownloader.cs:line 124
   at Wabbajack.Downloaders.DownloadDispatcher.Download(Archive a, AbsolutePath dest, Job`1 job, CancellationToken token, Nullable`1 useProxy) in c:\oss\wabbajack\Wabbajack.Downloaders.Dispatcher\DownloadDispatcher.cs:line 116
   at Wabbajack.Downloaders.DownloadDispatcher.Download(Archive a, AbsolutePath dest, CancellationToken token, Nullable`1 proxy) in c:\oss\wabbajack\Wabbajack.Downloaders.Dispatcher\DownloadDispatcher.cs:line 57
   at Wabbajack.Downloaders.DownloadDispatcher.DownloadFromMirror(Archive archive, AbsolutePath destination, CancellationToken token) in c:\oss\wabbajack\Wabbajack.Downloaders.Dispatcher\DownloadDispatcher.cs:line 252

The old downloader used to give an error message if the download failed. The new one somtimes just shows a size difference, or more often than not just a hash fail.

Wabbajack Version

3.7.5.2

Logs

Wabbajack.current(25).log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant