Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use functional options pattern for initialising NodeServer #76

Open
5 tasks
vadasambar opened this issue Nov 30, 2023 · 2 comments
Open
5 tasks

Use functional options pattern for initialising NodeServer #76

vadasambar opened this issue Nov 30, 2023 · 2 comments
Labels
help-wanted Extra attention is needed

Comments

@vadasambar
Copy link
Contributor

Based on #71 (comment)

Other refs around this pattern:

TODO

  • identify places where such pattern can be used in the code
  • make changes in such places
  • create a PR
  • get it reviewed and merged
  • DONE
@vadasambar vadasambar mentioned this issue Nov 30, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 17, 2024
@mbtamuli
Copy link
Contributor

@mugdha-adhav Please add one of the labels mentioned here - https://github.com/warm-metal/csi-driver-image/blob/master/docs/automation.md#maintenance

Maybe help-wanted

@mugdha-adhav mugdha-adhav added the help-wanted Extra attention is needed label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbtamuli @vadasambar @mugdha-adhav