Skip to content

Commit 0c5939b

Browse files
authored
Merge pull request #314 from wasmx/tidy
Drop a clang analyzer warning suppression
2 parents 94fe827 + 3ba1955 commit 0c5939b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/fizzy/execute.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -565,11 +565,7 @@ std::unique_ptr<Instance> instantiate(Module module,
565565

566566
// We need to create instance before filling table,
567567
// because table functions will capture the pointer to instance.
568-
//
569-
// TODO: clang-tidy warns about potential memory leak for moving memory (which is in fact
570-
// safe), but also erroneously points this warning to std::move(table)
571568
auto instance = std::make_unique<Instance>(std::move(module), std::move(memory), memory_limits,
572-
// NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks)
573569
std::move(table), table_limits, std::move(globals), std::move(imported_functions),
574570
std::move(imported_globals));
575571

0 commit comments

Comments
 (0)