Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failed checks related to dashboard and indexer since 4.9.0 #2901

Closed
MarcelKemp opened this issue Apr 4, 2024 · 2 comments · Fixed by #2909
Closed

Prevent failed checks related to dashboard and indexer since 4.9.0 #2901

MarcelKemp opened this issue Apr 4, 2024 · 2 comments · Fixed by #2909
Assignees
Labels
level/task Subtask issue type/change Change requested

Comments

@MarcelKemp
Copy link
Member

Wazuh version
4.9.0

Description

Due to the redesign of packages, and their corresponding migration, carried out in the following issue:

It is intended to prevent checks related to the dashboard and indexer from failing due to lack of updates. Because from 4.9.0 onwards, maintenance, and upgrades will be done in their own repositories.

To avoid failed checks, we want to prevent them from being triggered when the base branch is 4.9.0 or higher, so we will have to remove these checks from the GHA workflows, as well as from the CI checks executed in Jenkins, so that they are not executed again for these versions.

Failed checks to avoid

Unattended install + Distributed cases

These checks are executed from Jenkins within the Wazuh CI group, so it is necessary to apply the necessary settings in the wazuh-jenkins repository to prevent the execution of these checks. It seems that the files related to the triggers is the following:

Password tool script tests

This other case, when executing also the unattended install script, it is necessary that it is not executed either, as it will fail as the previous ones. In order not to execute it, it is simply necessary to delete the triggers (on pull request) that are in the workflow:

@MarcelKemp MarcelKemp added level/task Subtask issue type/change Change requested labels Apr 4, 2024
@MarcelKemp MarcelKemp self-assigned this Apr 4, 2024
@wazuhci wazuhci moved this to Backlog in Release 4.9.0 Apr 4, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.9.0 Apr 9, 2024
@MarcelKemp MarcelKemp linked a pull request Apr 15, 2024 that will close this issue
@MarcelKemp
Copy link
Member Author

MarcelKemp commented Apr 15, 2024

Update 15/04

After being able to resume this issue (due to other higher priority issues), I have investigated the checks that are run for dashboard and indexer, and I am making the necessary changes to both wazuh-packages and wazuh-jenkins to prevent them from running:

Update 16/04

PRs ready for review:

@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Apr 16, 2024
@rauldpm
Copy link
Member

rauldpm commented Apr 16, 2024

This issue does not match with the used objective, those checks are owned by other teams. Why is this being worked by the Core team and with this objective?

@wazuhci wazuhci moved this from Pending review to Done in Release 4.9.0 Apr 17, 2024
This was referenced Apr 30, 2024
@wazuhci wazuhci removed this from Release 4.9.0 May 9, 2024
@wazuhci wazuhci removed this from Release 4.9.0 May 9, 2024
@wazuhci wazuhci moved this to Done in Release 4.9.0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Subtask issue type/change Change requested
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants