Idempotency is broken

[poloz-lab]

What I can see

Each Puppet run executes an apt update :

Notice: /Stage[main]/Wazuh::Repo/Exec[apt-update]/returns: executed successfully (corrective)

Even if there is nothing to do. Which is against the key concept of Puppet idempotency

Now my Puppet dashboard is like a Christmas tinsel, saying that all my machines are changing their state.

What I expect

On the second Puppet run, Puppet must not do anything since the first run has already configured everything.

puppet agent -t must return 0 and not 2

Clues

The bug seems introduced in #1256 with the removal of the refresh-only parameter.

[vcerenu]

Hello @poloz-lab

Thank you very much for your contribution, I have reviewed and correctly we had a problem with the idempotence of the wazuh::repo class, so we proceeded to add this fix within our next version.

[poloz-lab]

Thanks !