Use NewPipelineReconciler in tests

The tests make their own `PipelineReconciler` struct, but there's a
constructor `NewPipelineReconciler` which could do some
initialisation, and that will missed. So: use the constructor in
suite-test.go.

However! This now fails to initialise the eventRecorder, leaving it to
default in `SetupWithManager`, and capturing events is part of the
tests.

I don't want to disturb existing behaviour*, so I've kept this change
to the level-triggered controller.

*How does it change? The event recorder is constructed using a
notification-controller URL and used _only_ for promotion
notifications. The event recorder for things that happen in the
reconciler is left to default, which means it won't send those to the
notification-controller. In practice it's unlikely to matter, since
any alerts set up should filter for the promotion events.

Signed-off-by: Michael Bridgen <[email protected]>

Author: squaremo

controllers/leveltriggered/controller.go

@@ -33,13 +33,14 @@ type PipelineReconciler struct {
 	stratReg       strategy.StrategyRegistry
 }
 
-func NewPipelineReconciler(c client.Client, s *runtime.Scheme, controllerName string, stratReg strategy.StrategyRegistry) *PipelineReconciler {
+func NewPipelineReconciler(c client.Client, s *runtime.Scheme, controllerName string, eventRecorder record.EventRecorder, stratReg strategy.StrategyRegistry) *PipelineReconciler {
 	targetScheme := runtime.NewScheme()
 
 	return &PipelineReconciler{
 		Client:         c,
 		Scheme:         s,
 		targetScheme:   targetScheme,
+		recorder:       eventRecorder,
 		ControllerName: controllerName,
 		stratReg:       stratReg,
 	}

controllers/leveltriggered/suite_test.go

@@ -133,13 +133,13 @@ func TestMain(m *testing.M) {
 
 	eventRecorder = &testEventRecorder{events: map[string][]testEvent{}}
 
-	pipelineReconciler = &PipelineReconciler{
-		Client:       k8sManager.GetClient(),
-		Scheme:       scheme.Scheme,
-		targetScheme: scheme.Scheme,
-		recorder:     eventRecorder,
-		stratReg:     strategy.StrategyRegistry{},
-	}
+	pipelineReconciler = NewPipelineReconciler(
+		k8sManager.GetClient(),
+		scheme.Scheme,
+		"pipelines",
+		eventRecorder,
+		strategy.StrategyRegistry{},
+	)
 	err = pipelineReconciler.SetupWithManager(k8sManager)
 	if err != nil {
 		log.Fatalf("setup pipeline controller failed: %s", err)

main.go

@@ -137,6 +137,7 @@ func main() {
 			mgr.GetClient(),
 			mgr.GetScheme(),
 			controllerName,
+			eventRecorder,
 			stratReg,
 		).SetupWithManager(mgr)
 	} else {