perf: IdentifierQueue

Author: SyMind

Cargo.lock

@@ -1973,7 +1973,7 @@ fn resolve_target(
       if already_visited.contains(&export_info_hash_key) {
         return Some(ResolvedExportInfoTargetWithCircular::Circular);
       }
-      let new_target = export_info.get_target_impl(mg, resolve_filter.clone(), already_visited);
+      let new_target = export_info.get_target_impl(mg, resolve_filter, already_visited);
 
       match new_target {
         Some(ResolvedExportInfoTargetWithCircular::Circular) => {

crates/rspack_core/src/exports_info.rs

@@ -9,7 +9,7 @@ use rspack_core::{
 };
 use rspack_error::Result;
 use rspack_hook::{plugin, plugin_hook};
-use rspack_util::queue::Queue;
+use rspack_util::queue::IdentifierQueue;
 use swc_core::ecma::atoms::Atom;
 
 pub struct FlagDependencyExportsState<'a> {
@@ -34,7 +34,7 @@ impl<'a> FlagDependencyExportsState<'a> {
   pub fn apply(&mut self, modules: IdentifierSet) {
     let start = self.logger.time("traverse modules");
 
-    let mut q = Queue::new();
+    let mut q = IdentifierQueue::new();
 
     for module_id in modules {
       let mgm = self
@@ -99,7 +99,7 @@ impl<'a> FlagDependencyExportsState<'a> {
   }
 
   // #[tracing::instrument(skip_all, fields(module = ?self.current_module_id))]
-  pub fn notify_dependencies(&mut self, q: &mut Queue<ModuleIdentifier>) {
+  pub fn notify_dependencies(&mut self, q: &mut IdentifierQueue) {
     if let Some(set) = self.dependencies.get(&self.current_module_id) {
       for mi in set.iter() {
         q.enqueue(*mi);
@@ -121,7 +121,7 @@ impl<'a> FlagDependencyExportsState<'a> {
     block: &B,
     exports_specs_from_dependencies: &mut UkeyIndexMap<DependencyId, ExportsSpec>,
   ) -> Option<()> {
-    for dep_id in block.get_dependencies().iter() {
+    for dep_id in block.get_dependencies() {
       let dep = self
         .mg
         .dependency_by_id(dep_id)

crates/rspack_plugin_javascript/src/plugin/flag_dependency_exports_plugin.rs

@@ -9,21 +9,22 @@ version     = "0.2.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-bitflags         = { workspace = true }
-concat-string    = { workspace = true }
-cow-utils        = { workspace = true }
-dashmap          = { workspace = true }
-indexmap         = { workspace = true }
-itoa             = { version = "1.0.14" }
-regex            = { workspace = true }
-ropey            = { workspace = true }
-rspack_cacheable = { workspace = true }
-rspack_paths     = { workspace = true }
-rustc-hash       = { workspace = true }
-serde            = { workspace = true }
-serde_json       = { workspace = true }
-sugar_path       = { workspace = true }
-unicase          = { workspace = true }
+bitflags           = { workspace = true }
+concat-string      = { workspace = true }
+cow-utils          = { workspace = true }
+dashmap            = { workspace = true }
+indexmap           = { workspace = true }
+itoa               = { version = "1.0.14" }
+regex              = { workspace = true }
+ropey              = { workspace = true }
+rspack_cacheable   = { workspace = true }
+rspack_collections = { workspace = true }
+rspack_paths       = { workspace = true }
+rustc-hash         = { workspace = true }
+serde              = { workspace = true }
+serde_json         = { workspace = true }
+sugar_path         = { workspace = true }
+unicase            = { workspace = true }
 
 swc_config = { workspace = true }
 swc_core   = { workspace = true, features = ["base", "ecma_ast"] }

crates/rspack_util/Cargo.toml

@@ -1,10 +1,14 @@
-use std::{collections::VecDeque, hash::Hash};
+use std::{
+  collections::{HashSet, VecDeque},
+  hash::{BuildHasher, BuildHasherDefault, Hash},
+};
 
-use rustc_hash::FxHashSet as HashSet;
+use rspack_collections::{Identifier, IdentifierHasher};
+use rustc_hash::FxBuildHasher;
 
-pub struct Queue<T: Hash + PartialEq + Eq + Clone> {
+pub struct Queue<T: Hash + PartialEq + Eq + Clone, S = FxBuildHasher> {
   q: VecDeque<T>,
-  set: HashSet<T>,
+  set: HashSet<T, S>,
 }
 
 impl<T: Hash + PartialEq + Eq + Clone> Default for Queue<T> {
@@ -13,11 +17,11 @@ impl<T: Hash + PartialEq + Eq + Clone> Default for Queue<T> {
   }
 }
 
-impl<T: Hash + PartialEq + Eq + Clone> Queue<T> {
+impl<T: Hash + PartialEq + Eq + Clone, S: BuildHasher + Default> Queue<T, S> {
   pub fn new() -> Self {
     Self {
       q: VecDeque::default(),
-      set: HashSet::default(),
+      set: HashSet::<T, S>::default(),
     }
   }
 
@@ -36,3 +40,5 @@ impl<T: Hash + PartialEq + Eq + Clone> Queue<T> {
     None
   }
 }
+
+pub type IdentifierQueue = Queue<Identifier, BuildHasherDefault<IdentifierHasher>>;