Skip to content

Commit fe09de7

Browse files
noamrchromium-wpt-export-bot
authored andcommitted
Rendering of corner-shape: bevel
This sets the infrastructure for rendering corner-shape, by storing 4-float "CornerCurvature" on a FloatRoundedRect. Currently only the special-case for "bevel" is handled, with the idea of iterating on the different aspects of rendering as we go along. To properly render bevel (and any other curvature that's lower than round), drawing a straight line from the outer/inner sides doesn't create the right effect, because the diagonal distance between those lines doesn't match the border width. To correct that, while maintaining rendering within the initial corners, the outer corner is shrunk to the point where the resulting diagonal quad has a width equal to the border-width (or interpolating between two border-widths). See open spec issue: w3c/csswg-drafts#11610 Removed existing hand-coded SVG tests, and generating the refs using a canvas polyfill instead. This polyfill can be amended later on as we polish the spec. Bug: 394059604 Change-Id: I9fb76dd7dc557ed10c40adecbb9f68f672de1acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6250197 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1421457}
1 parent ce49a42 commit fe09de7

File tree

60 files changed

+243
-873
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+243
-873
lines changed

Diff for: css/css-borders/reference/corner-shape-angle-bottom-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-bottom-left-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-bottom-right-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-left-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-right-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-top-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-top-left-bottom-right-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-top-left-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-top-right-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-angle-top-right-bottom-left-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-round-bottom-left-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-round-bottom-right-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-round-top-left-ref.html

-8
This file was deleted.

Diff for: css/css-borders/reference/corner-shape-round-top-right-001-ref.html

-8
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-all.svg

-13
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-bottom-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-bottom-right.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-bottom.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-right.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-top-left-bottom-right.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-top-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-top-right-bottom-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-top-right.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-angle-top.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-round-bottom-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-round-bottom-right.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-round-top-left.svg

-12
This file was deleted.

Diff for: css/css-borders/support/corner-shape-round-top-right.svg

-12
This file was deleted.

Diff for: css/css-borders/tentative/corner-shape/corner-shape-angle-001.html

-22
This file was deleted.

Diff for: css/css-borders/tentative/corner-shape/corner-shape-angle-002.html

-22
This file was deleted.

Diff for: css/css-borders/tentative/corner-shape/corner-shape-angle-003.html

-22
This file was deleted.

0 commit comments

Comments
 (0)