Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebPushClient: Implement an interface for mocking in UnitTests #79

Closed
kristof12345 opened this issue Apr 8, 2021 · 1 comment
Closed

WebPushClient: Implement an interface for mocking in UnitTests #79

kristof12345 opened this issue Apr 8, 2021 · 1 comment

Comments

@kristof12345
Copy link

Hi!

When trying to make unit tests for my app it'd be really useful to mock WebPushClient. For this creating an abstract base class or an interface would be really useful (or just making SendNotificationAsync overridable).

Thank you!
coryjthompson added a commit that referenced this issue Jul 3, 2021
@coryjthompson
#79 Implement an interface for mocking in UnitTests
69eaa49
@coryjthompson
Copy link
Member

Thanks for your advice.

IWebPushClient was introduced for mocking and released in v1.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coryjthompson @kristof12345