Skip to content

Commit 14abde7

Browse files
justinfagnanibicknellrrictic
authored
[scoped-custom-element-registry] Port to TypeScript (#561)
* Fix eslintignore sync * Port to TypeScript * Some non-type changes * Apply suggestions from code review Co-authored-by: Russell Bicknell <[email protected]> * Add type for form state * Give explicit types for Maps, Sets, WeakMaps * Add some comments and readonly markers * Update deps * Fix two build issues Some TypeScripts need resolve explicitly typed, and some closure compiler versions need the `whenDefined` method on our registry ponyfill quoted. * Add comment about how the main file is a script not a module. * Minor updates to comments. --------- Co-authored-by: Russell Bicknell <[email protected]> Co-authored-by: Peter Burns <[email protected]>
1 parent 651e207 commit 14abde7

10 files changed

+3131
-1644
lines changed

.eslintignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,7 @@ packages/webcomponentsjs/src/unresolved.*
4040
packages/webcomponentsjs/custom-elements-es5-adapter.js
4141
packages/webcomponentsjs/webcomponents-bundle.d.ts
4242
packages/webcomponentsjs/webcomponents-bundle.js*
43+
44+
packages/scoped-custom-element-registry/**/.wireit/
45+
packages/scoped-custom-element-registry/**/.tsbuildinfo
46+
packages/scoped-custom-element-registry/**/build/

.eslintignore-sync

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
[local]
22
.gitignore
3+
4+
[relative]
5+
packages/*/{.gitignore,.eslintignore}

.prettierignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ packages/webcomponentsjs/webcomponents-bundle.d.ts
4242
packages/webcomponentsjs/webcomponents-bundle.js*
4343

4444
packages/scoped-custom-element-registry/**/.wireit/
45+
packages/scoped-custom-element-registry/**/.tsbuildinfo
46+
packages/scoped-custom-element-registry/**/build/
4547

4648
LICENSE
4749
packages/*/LICENSE.md
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
.wireit/
2+
.tsbuildinfo
3+
build/

packages/scoped-custom-element-registry/closure-flags.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
--language_in=STABLE
44
--language_out=ECMASCRIPT5_STRICT
55
--dependency_mode=PRUNE
6-
--entry_point=./src/scoped-custom-element-registry.js
7-
--js=./src/scoped-custom-element-registry.js
6+
--entry_point=./build/scoped-custom-element-registry.js
7+
--js=./build/scoped-custom-element-registry.js
88
--js_output_file=./scoped-custom-element-registry.min.js
99
--output_wrapper="(function(){
1010
%output%
@@ -14,4 +14,5 @@
1414
--assume_function_wrapper=true
1515
--rewrite_polyfills=false
1616
--create_source_map=./scoped-custom-element-registry.min.js.map
17+
--source_map_input="./build/scoped-custom-element-registry.js|./build/scoped-custom-element-registry.js.map"
1718
--source_map_include_content

0 commit comments

Comments
 (0)