Skip to content

Commit 44d5e0b

Browse files
Bug fix: Optional sequences shouldn't be defaulted to null
MLArgMinMaxOptions and MLReduceOptions have an 'axes' member that the IDL declares as defaulting to null. They have type sequence<unsigned long> which is not nullable. The intent is that these are optional members with default behavior if not present, which is handled in the algorithm already.
1 parent d1a02f2 commit 44d5e0b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

index.bs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1477,7 +1477,7 @@ Return the index location of the minimum or maxmium values of all the input valu
14771477

14781478
<script type=idl>
14791479
dictionary MLArgMinMaxOptions {
1480-
sequence<unsigned long> axes = null;
1480+
sequence<unsigned long> axes;
14811481
boolean keepDimensions = false;
14821482
boolean selectLastIndex = false;
14831483
};
@@ -4914,7 +4914,7 @@ partial interface MLGraphBuilder {
49144914
Reduce the input tensor along all dimensions, or along the axes specified in the {{MLReduceOptions/axes}} array parameter. For each specified axis, the dimension with that index is reduced, i.e. the resulting tensor will not contain it, unless the {{MLReduceOptions/keepDimensions}} option is specified. The values of the resulting tensor are calculated using the specified reduction function that takes as parameters all the values across the reduced dimension.
49154915
<script type=idl>
49164916
dictionary MLReduceOptions {
4917-
sequence<unsigned long> axes = null;
4917+
sequence<unsigned long> axes;
49184918
boolean keepDimensions = false;
49194919
};
49204920

0 commit comments

Comments
 (0)