Skip to content

Commit 6e19654

Browse files
fdwrinexorabletashhuningxin
authored
Operator set wave 3 (#805)
* Wave 3 skeleton * Add cumulativeSum * Update more operators * Updates * Copy pasta cleanup - feedback updates pending * Rank typo for Q and DQ * CR feedback * Forgot feedback - delete Increment dimCount by one. * Add blockwise broadcastable dimension. Add Q/DQ emulation and more complete algorithm. * Fix bikeshed errors * More bikeshed errors * CR feedback, renamed scatterNd/gatherNd, add gatherElements/scatterElements examples, fix flatten on edge conditions * Fix more bikeshed errors * Add gather/scatterElements algorithm steps. Add gather/scatterNd examples. Fix bool bikeshed issue in cumulativeSum. * scatter* use atop a copy wording * Simplify blockwise broadcasting removing temporaries * Bikeshed asymmetric bracket * GatherND make example more interesting * Gather example fixes * Add gatherND and scatterND algorithm steps * Rename gatherND and scatterND to ND again for now to be consistent with current implementation, tracked by separate issue * Update slice algorithm steps for strides * Fix slice algorithm slice size * Update blockwise broadcasting to return true/false * Fix bikeshed naming for rankInput vs inputRank etc * Apply Joshua's helpful suggestions. Co-authored-by: Joshua Bell <[email protected]> * Refix udpates after merge conflict * More of Joshua's suggestions Co-authored-by: Joshua Bell <[email protected]> * Add reverse inputRank * More of Joshua's suggestions 👍🙏 Co-authored-by: Joshua Bell <[email protected]> * Fix a/an wording * More list/equal occurrences * Summation vs addition * Bikeshed unbalanced table in cumulativeSum * Bikeshed reverse inputRank * Merge Joshua's code suggestions for arg references 👏 Co-authored-by: Joshua Bell <[email protected]> Co-authored-by: Ningxin Hu <[email protected]> * Address most of Ningxin's feedback * Remaining feedback from Ningxin * Fix bikeshed --------- Co-authored-by: Joshua Bell <[email protected]> Co-authored-by: Ningxin Hu <[email protected]>
1 parent 4449c97 commit 6e19654

File tree

1 file changed

+1631
-143
lines changed

1 file changed

+1631
-143
lines changed

0 commit comments

Comments
 (0)