Skip to content

Commit c4c369a

Browse files
Wording: Use shorter possessive form for abstract object properties (#565)
* Bug fix: Correct "rank of op's shape" to just "rank of op" MLOperands have a rank; the shape just has a size. * Wording: Use shorter possessive form for abstract object properties Old and busted: ... the [=property=] of |object| ... New hotness: ... |object|'s [=property=] ... Discussed in #555 (comment) * Bug fix: Dedupe some words I noticed "then then" in the previous commit and searched for similar glitches to fix. * Bug fix: Incorrect referencing operand properties * Erroneously referencing descriptor properties, but directly against an operand. This can be fixed by using the shape and dataType shortcuts. (6 cases) * Simplifications where an operand's shape shortcut could be used. (3 cases)
1 parent 745ddbc commit c4c369a

File tree

2 files changed

+64
-63
lines changed

2 files changed

+64
-63
lines changed

docs/SpecCodingConventions.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Example:
5454
```
5555
The <dfn>maximum size</dfn> of a collection is...
5656
57-
1. Let |max| be the [=maximum size=] of |collection|.
57+
1. Let |max| be |collection|'s [=maximum size=].
5858
```
5959

6060
* When defining subsidiary terms, like properties of an object, members of an enum, etc, scope the definitions using `dfn-for` on the `dfn` or an ancestor.
@@ -96,6 +96,7 @@ Example:
9696
* Use `[=list/For each=] |index| in [=the range=] X to Y, inclusive` when iterating over a numeric range; a range is implicitly an ordered set which is a type of list. Specify _inclusive_ or _exclusive_ regarding the upper bound, for clarity.
9797
* Use "let" to introduce a variable and "set" to update a variable or assign to a property.
9898
* Use « » notation for literal lists, which helps make it clear that they are not JavaScript arrays.
99+
* When referring to abstract properties, use the short possessive form `|object|'s [=property=]`. Avoid the wordier `the [=property=] of |object|` form.
99100

100101

101102
### Method Definitions

0 commit comments

Comments
 (0)