Skip to content

Commit d2ce8d3

Browse files
Bug fix: Optional sequences shouldn't be defauled to null
MLArgMinMaxOptions and MLReduceOptions have an 'axes' member that the IDL declares as defaulting to null. They have type sequence<unsigned long> which is not nullable. The intent is that these are optional members with default behavior if not present, which is handled in the algorithm already.
1 parent 479ce17 commit d2ce8d3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

index.bs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1478,7 +1478,7 @@ Return the index location of the minimum or maxmium values of all the input valu
14781478

14791479
<script type=idl>
14801480
dictionary MLArgMinMaxOptions {
1481-
sequence<unsigned long> axes = null;
1481+
sequence<unsigned long> axes;
14821482
boolean keepDimensions = false;
14831483
boolean selectLastIndex = false;
14841484
};
@@ -4948,7 +4948,7 @@ partial interface MLGraphBuilder {
49484948
Reduce the input tensor along all dimensions, or along the axes specified in the {{MLReduceOptions/axes}} array parameter. For each specified axis, the dimension with that index is reduced, i.e. the resulting tensor will not contain it, unless the {{MLReduceOptions/keepDimensions}} option is specified. The values of the resulting tensor are calculated using the specified reduction function that takes as parameters all the values across the reduced dimension.
49494949
<script type=idl>
49504950
dictionary MLReduceOptions {
4951-
sequence<unsigned long> axes = null;
4951+
sequence<unsigned long> axes;
49524952
boolean keepDimensions = false;
49534953
};
49544954

0 commit comments

Comments
 (0)