Skip to content

Commit ef800fb

Browse files
Bug fix: Optional sequences shouldn't be defaulted to null
MLArgMinMaxOptions and MLReduceOptions have an 'axes' member that the IDL declares as defaulting to null. They have type sequence<unsigned long> which is not nullable. The intent is that these are optional members with default behavior if not present, which is handled in the algorithm already.
1 parent c9d2dd7 commit ef800fb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

index.bs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1480,7 +1480,7 @@ Return the index location of the minimum or maxmium values of all the input valu
14801480

14811481
<script type=idl>
14821482
dictionary MLArgMinMaxOptions {
1483-
sequence<unsigned long> axes = null;
1483+
sequence<unsigned long> axes;
14841484
boolean keepDimensions = false;
14851485
boolean selectLastIndex = false;
14861486
};
@@ -4917,7 +4917,7 @@ partial interface MLGraphBuilder {
49174917
Reduce the input tensor along all dimensions, or along the axes specified in the {{MLReduceOptions/axes}} array parameter. For each specified axis, the dimension with that index is reduced, i.e. the resulting tensor will not contain it, unless the {{MLReduceOptions/keepDimensions}} option is specified. The values of the resulting tensor are calculated using the specified reduction function that takes as parameters all the values across the reduced dimension.
49184918
<script type=idl>
49194919
dictionary MLReduceOptions {
4920-
sequence<unsigned long> axes = null;
4920+
sequence<unsigned long> axes;
49214921
boolean keepDimensions = false;
49224922
};
49234923

0 commit comments

Comments
 (0)